Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make api keys optional #54

Open
DavidDTA opened this issue May 14, 2022 · 2 comments
Open

Make api keys optional #54

DavidDTA opened this issue May 14, 2022 · 2 comments
Assignees

Comments

@DavidDTA
Copy link

API keys are not required when using OAuth, and I believe providing one should not be required to create a Firestore.Config value.

@IzumiSy IzumiSy self-assigned this May 14, 2023
@IzumiSy
Copy link
Owner

IzumiSy commented May 14, 2023

In OAuth, Firebase REST API requires us to pass OAuth 2.0 token on Authorization header as the doc says.
https://firebase.google.com/docs/firestore/use-rest-api

So it should be required.

@DavidDTA
Copy link
Author

The OAuth 2.0 token is passed via withAuthorization. However, in order to create a Config value, you must use Config.new, which requires an apiKey. The apiKey should be optional since it's not needed when withAuthorization is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants