Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate API Goal #25

Open
2 of 4 tasks
heydayle opened this issue Apr 17, 2023 · 2 comments
Open
2 of 4 tasks

Integrate API Goal #25

heydayle opened this issue Apr 17, 2023 · 2 comments
Assignees
@heydayle
Labels
bug Something isn't working Goal Goal feature

Comments

@heydayle
Copy link
Member

  • List Goal and filter
  • Create Goal
  • Edit Goal
  • Delete Goal
@heydayle heydayle self-assigned this Apr 17, 2023
@heydayle
Copy link
Member Author

@wawahuy currently API return 403 error, I can't get data and create goal.
Screen Shot 2023-04-18 at 01 14 52

@heydayle heydayle added the bug Something isn't working label Apr 17, 2023
@wawahuy
Copy link
Member

wawahuy commented Apr 18, 2023 •
edited
Loading

Please add userId in filter search or userId in insert/update. because i use it for authorization.
Passing userId seems redundant and bandwidth consuming, but it saves cpu and flexible scalability.
@heydayle

https://github.com/Investiway/investiway-back/blob/d9695f3f784bbd15f7332ce41ac083c3abbb2ef7/apps/investiway/src/controllers/goal.controller.ts#L72

https://github.com/Investiway/investiway-back/blob/d9695f3f784bbd15f7332ce41ac083c3abbb2ef7/apps/investiway/src/services/goal.service.ts#L140

@heydayle heydayle added the Goal Goal feature label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heydayle heydayle

Labels
bug Something isn't working Goal Goal feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wawahuy @heydayle