Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - cardano-testnet Use flags to specify the output directory for the cluster artifacts #6078

Open
1 of 17 tasks
CarlosLopezDeLara opened this issue Jan 17, 2025 · 0 comments

Comments

@CarlosLopezDeLara
Copy link
Contributor

What

Update cardano-testnet such that we can do

cardano-testnet cardano --testnet-magic 44 --output-dir ./cluster

Ass opposed to the current behavior where the files are dropped to the tmp directory with a random directory name like:
Workspace: /tmp/testnet-test-d80a00cb819aaf91

Why

This enhances user experience and helps users to have more control over their workflow when using cardano-testnet.

Acceptance Criteria

When running

cardano-testnet cardano --testnet-magic 44 --output-dir <DIR>
  1. All the artifacts to run the cluster are created under the specified directory
  2. If the directory does not exist, cardano-testnet creates it.

Personas

  • SPOs
  • dApp Devs
  • Exchanges
  • Wallets
  • 3rd party tools
  • ADA holders

Definition of Done (DoD)

  • Acceptance Criteria + User Stories & DoD created and singed-off (by PO, dev & test owners)
  • Builds successfully on CI
  • Code & Test review (as per Acceptance Criteria)
  • There is documentation and/or examples for the new functionality (usage/response)
  • Log/record changes on Vnext (or similar depending on what we adopt)
  • Ticket number(s) included in PR description
  • All Acceptance Criteria met and covered by dev/unit/property/integration tests
  • System/E2E automated tests + System Test Engineer Owner Sign-off

NOTE: Ideally, we should merge only fully implemented and tested features into the master branch.
So all the above steps are required for the PR to be merged.
In order to avoid the PRs becoming stale and requiring to be rebased on master, these can be merged
after a reasonable time (current agreement is 3 days) if the System Test Engineer Owner's sign-off
was not provided (last step in the DoD).

IMPORTANT: Any deviation from the plan should be discussed and agreed as a comment in the Feature file.

Sign-off

  • Product Owner
  • Dev Owner
  • System Test Engineer Owner

Related PRs

  1. PR # here
@CarlosLopezDeLara CarlosLopezDeLara added needs triage Issue / PR needs to be triaged. user type: internal Created by an IOG employee cardano-testnet comp: cardano-testnet and removed needs triage Issue / PR needs to be triaged. labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant