Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add more interactive events on monitor and computer for players #12

Open
zyxkad opened this issue Apr 24, 2023 · 7 comments · May be fixed by IntelligenceModding/AdvancedPeripherals#650
Assignees
Labels
Milestone

Comments

@zyxkad
Copy link
Collaborator

zyxkad commented Apr 24, 2023

Describe your idea

Make monitors and computers can identify player in actions

We should still queue monitor_touch event, but add player's name as the last value

Describe alternatives you've considered if you've any

N/A

Additional context

probably mouse events and key presses can also have this param,
and if on computer, you may add new events called player_open or player_closed to open or close computer,
for player_open, the program may abort the action

Linked Issues

No response

@zyxkad zyxkad changed the title [Feature Request] Add a player_name param to monitor_touch event [Feature Request] Add more interactive events on monitor and computer for players Apr 24, 2023
@SirEndii
Copy link
Member

I doubt that I'll ever do soemthing like this. I would not add/change an existing event - that would be better if CC:T implements itself and adding a new monitor isn't something I want to do

@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 25, 2023

I doubt that I'll ever do soemthing like this. I would not add/change an existing event - that would be better if CC:T implements itself and adding a new monitor isn't something I want to do

Well, but CC:T won't impl that cc-tweaked/CC-Tweaked#596

@SirEndii
Copy link
Member

Yeah, but I don't get around adding this for 0.8
Someone could make a pr - but AP is currently a bit paused for me

@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 26, 2023

Nvm, if I have time I can try to implement it (probably not, I don't know much about forge api).

@zyxkad
Copy link
Collaborator Author

zyxkad commented Apr 27, 2023

I check the CC:T codes, if I want to impl that, I should use mixin, because the signature of the monitorTouched method don't have player param. I'm not sure if you would like to do that.

    void monitorTouched(float xPos, float yPos, float zPos)

@SirEndii
Copy link
Member

Yeah. That's a reason why I do bot want to add features to existing blocks from CC

@SirEndii SirEndii transferred this issue from IntelligenceModding/AdvancedPeripherals Nov 9, 2023
@zyxkad zyxkad added the area-misc $*%^@)(&$^%(@# label Jul 22, 2024
@zyxkad
Copy link
Collaborator Author

zyxkad commented Jul 22, 2024

I may working on this with #6 , so both transparentable and identifiable on same block
this or next month if possible

@zyxkad zyxkad self-assigned this Jul 22, 2024
@zyxkad zyxkad added this to the 0.8r milestone Jul 22, 2024
@zyxkad zyxkad linked a pull request Jul 26, 2024 that will close this issue
3 tasks
@zyxkad zyxkad linked a pull request Jul 26, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants