Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sunset Mock Helper #13

Open
norton120 opened this issue Mar 22, 2019 · 0 comments
Open

Sunset Mock Helper #13

norton120 opened this issue Mar 22, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@norton120
Copy link
Contributor

Description

Tests should be clean and self contained. Fetch tests still have the mock helper lib that only helps to obfuscate much of the code.
We want to refactor the tests to :

  • remove the mock helper
  • cook up a series of small stubs (s3, dataframe) that can be used easily and modularly through all of the fetch tests.

Why?

The fetch tests are more brittle and harder to maintain than we would like at this time. This helps future us!
@norton120 norton120 added enhancement New feature or request good first issue Good for newcomers labels Mar 22, 2019
RyanAdalbert pushed a commit to RyanAdalbert/s3parq that referenced this issue Sep 16, 2019
@norton120
Merge pull request IntegriChain1#13 from norton120/DC-39-contract-get…
2475627 
…ter-setter

Adds publish_raw_file to contract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@norton120