Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmp folder PR - bug #218

Open
hadrilec opened this issue Sep 12, 2024 · 7 comments
Open

tmp folder PR - bug #218

hadrilec opened this issue Sep 12, 2024 · 7 comments

Comments

@hadrilec
Copy link
Contributor

hadrilec commented Sep 12, 2024

@tgrandje I merged the PR on tmp folder, but apparently tests are not successful. Would you mind to have a look?
I can also remove the last commit if need be 94137fb

@tgrandje
Copy link
Collaborator

@hadrilec are you speaking of those tests?

If so, there is nothing useful in those logs but the (yet again) timeout. I'll ran those on my laptop to check if there's anything to do about it.

If my fears are confirmed (that is, that tests on github are now unreliable for unknown reasons), do you think we should test this on multiple python versions?

By the way, do you know if there might be a problem of shared ressources between pynsee and another project stored in InseeFrLab? I don't really know how github allocates ressources...

@tgrandje
Copy link
Collaborator

OK, the 3.10 tests ran like a charm, but only 32 tests where selected. I'll retry that after having removed the versions filters.

@tgrandje
Copy link
Collaborator

So I confirm everything worked fine on my laptop (84 tests passed in 43min).
I vote to close this issue and get back on testing the impact of caching!

@hadrilec
Copy link
Contributor Author

good that it works on your computer

@tfardet
Copy link
Collaborator

tfardet commented Sep 18, 2024

rereading the code, shouldn't it be a call to tempfile.TemporaryDirectory() here?

@tgrandje
Copy link
Collaborator

@tfardet in fact it's moved here

@tfardet
Copy link
Collaborator

tfardet commented Sep 18, 2024

ah right, I misread, sorry for the noise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants