Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymorpshism for table cells objects #276

Open
nsenave opened this issue Dec 12, 2024 · 0 comments
Open

Polymorpshism for table cells objects #276

nsenave opened this issue Dec 12, 2024 · 0 comments

Comments

@nsenave
Copy link
Contributor

nsenave commented Dec 12, 2024

Currently table components Table and RosterForLoop use a dirty BodyCell object.

The reason ComponentType is not used instead is probably due to the fact that a table cell could be a simple static label, and LabelType has nothing to share with ComponentType.

Yet, Lunatic now uses a Text component, and it is recommended to use this one instead of a LabelType object in tables.

Then, it is now appropriate to refactor and remove the BodyCell object, to replace it by ComponentType.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant