Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12] Plant Interactor drops dupe crops on the floor #624

Closed
mpavkovic opened this issue Nov 15, 2019 · 4 comments
Closed

[1.12] Plant Interactor drops dupe crops on the floor #624

mpavkovic opened this issue Nov 15, 2019 · 4 comments

Comments

@mpavkovic
Copy link

mpavkovic commented Nov 15, 2019

**Industrial Foregoing Version: **

  • 1.12.12-236
  • 1.12.13-237

**TeslaCoreLib Version: ** 1.0.15

**Crashlog If Applicable (Upload to pastebin/gist): ** N/A

Plant Interactor drops duplicate crops and seeds on the floor when interacting with vanilla crops (tested on 9x9 wheat farm, Sky Factory 4 modpack, version 4.1.0). I've seen a similar issue reported, caused by Simple Harvest, but that mod is not in the modpack. Manually updating IF to newer version didn't help. Analogous machine from Cyclic mod (Harvester) works fine.

Here is a list of mods included in the pack
Advancement_Book-1.12-1.0.3.jar
ae2stuff-0.7.0.4-mc1.12.2.jar
AnimalCrops-1.12.2-0.2.0.jar
Apotheosis-1.12.2-1.10.5.jar
AppleCore-mc1.12.2-3.2.0.jar
AppleSkin-mc1.12-1.0.9.jar
appliedenergistics2-rv6-stable-7.jar
Aroma1997Core-1.12.2-2.0.0.2.b165.jar
AromaBackup-1.12.2-3.0.0.0.b125.jar
astralsorcery-1.12.2-1.10.19.jar
BarrelsDrumsStorageAndMore-0.0.24.jar
base-1.12.2-3.11.0.jar
Baubles-1.12-1.5.2.jar
bdlib-1.14.3.12-mc1.12.2.jar
bedpatch-2.2-1.12.2.jar
BetterAdvancements-1.12.2-0.1.0.77.jar
BiblioCraft[v2.4.5][MC1.12.2].jar
BNBGamingCore-1.12.2-0.11.0.jar
BNBGamingLib-1.12.2-2.17.6.jar
bonsaitrees-1.1.3-b156.jar
Bookshelf-1.12.2-2.3.581.jar
BouncyCreepers-0.0.4.jar
BuildingGadgets-2.6.8.jar
Caliper-1.12.2-1.1.45.jar
CalmDownZombieGuy-1.12.2-1.0.0.jar
CarryOn MC1.12.2 v1.12.2.jar
Ceramics-1.12-1.3.7.jar
Chargers-1.12.2-1.2.0.4.jar
ChineseWorkshop-1.12.2_1.2.6.jar
Chisel-MC1.12.2-0.2.1.35.jar
chiselsandbits-14.32.jar
ClickMachine-1.12.2-1.2.0.jar
ClientTweaks_1.12.2-3.1.11.jar
Clumps-3.1.2.jar
CodeChickenLib-1.12.2-3.2.3.357-universal.jar
CoFHCore-1.12.2-4.6.3.27-universal.jar
CoFHWorld-1.12.2-1.3.1.7-universal.jar
ColouredTooltips-1.12.2-1.0.7.jar
CommonCapabilities-1.12.2-2.1.0.jar
compactmachines3-1.12.2-3.0.18-b278.jar
CompactStorage-3.1-12.jar
ComPatchedStorage-1.12.2-1.6.0.jar
conarm-1.12.2-1.2.4.jar
ContentTweaker-1.12.2-4.9.1.jar
Controlling-3.0.6.jar
CookingForBlockheads_1.12.2-6.4.71.jar
CraftTweaker2-1.12-4.1.18.jar
CTM-MC1.12.2-0.3.3.22.jar
Cucumber-1.12.2-1.1.3.jar
culinaryconstruct-1.3.3.jar
CustomMainMenu-MC1.12.2-2.0.9.jar
Cyclic-1.12.2-1.19.14.jar
CyclopsCore-1.12.2-1.0.6.jar
DarkUtils-1.12.2-1.8.226.jar
deepmoblearning-1.12.2-2.5.2-universal.jar
DefaultOptions_1.12.2-9.2.8.jar
DimensionStages-1.12.2-2.0.23.jar
DragonMurder-1.12.2-1.0.1.jar
ElevatorMod-1.12.2-1.4.2.jar
EnchantmentDescriptions-1.12.2-1.1.15.jar
EnderCore-1.12.2-0.5.57.jar
endercrop-1.12.2-1.6.0.jar
EnderStorage-1.12.2-2.4.6.137-universal.jar
enderutilities-1.12.2-0.7.12.jar
ExtendedCrafting-1.12.2-1.5.4.jar
ExtraCells-1.12.2-2.6.2a.jar
FancyBlockParticles-1.12.x-2.4.1.jar
FarmingForBlockheads_1.12.2-3.1.26.jar
FastFurnace-1.12.2-1.3.1.jar
FastWorkbench-1.12.2-1.7.2.jar
FenceOverhaul-1.3.4.jar
findme-1.12.2-1.1.0-8.jar
fluxnetworks-1.12.2-3.0.19-21.jar
foamfix-0.10.5-1.12.2.jar
Forgelin-1.8.2.jar
ForgeMultipart-1.12.2-2.6.1.81-universal.jar
ForgivingVoid_1.12.2-1.0.23.jar
GameStages-1.12.2-2.0.115.jar
Guide-API-1.12-2.1.8-63.jar
Headcrumbs-1.12.2-2.0.5.17.jar
HorsePower-1.12.2-2.6.4.74.jar
HuntingDimension-1.12.2-1.0.38.jar
HurtAnimationRemover-1.12.2-1.0.0.jar
Hwyla-1.8.26-B41_1.12.2.jar
HydroGel-1.12.2-1.1.0.jar
iChunUtil-1.12.2-7.1.4.jar
incontrol-1.12-3.9.10.jar
industrialforegoing-1.12.2-1.12.12-236.jar
Inspirations-1.12.2-0.2.6.jar
IntegratedDynamics-1.12.2-1.0.8.jar
IntegratedTunnels-1.12.2-1.6.7.jar
inventorysorter-1.12.2-1.13.3+57.jar
IronJetpacks-1.12-2-1.1.0.jar
ItemStages-1.12.2-2.0.50.jar
jei_1.12.2-4.15.0.289.jar
journeymap-1.12.2-5.5.5.jar
KleeSlabs_1.12.2-5.4.11.jar
LimitlessStructureBlocks-1.12.2-1.1.0.jar
LoadingScreens-1.12.2-0.3.1.jar
lostcities-1.12-2.0.17.jar
malisiscore-1.12.2-6.5.1.jar
malisisdoors-1.12.2-7.3.0.jar
Mantle-1.12-1.3.3.55.jar
MatterOverdrive-1.12.2-0.7.1.0-universal.jar
mcjtylib-1.12-3.1.1.jar
MCMultiPart-2.5.3.jar
Mekanism-1.12.2-9.8.0.381.jar
MekanismGenerators-1.12.2-9.8.0.381.jar
Mercurius-1.12.2.jar
MobGrindingUtils-0.3.13.jar
MobStages-1.12.2-2.0.13.jar
modtweaker-4.0.17.jar
More-Cauldrons-1.4.5.jar
MoreBuckets-1.12.2-1.0.4.jar
moreoverlays-1.14-mc1.12.2.jar
Morpheus-1.12.2-3.5.106.jar
MouseTweaks-2.10-mc1.12.2.jar
mpbasic-1.12.2-1.4.11.jar
MPUtils-1.12.2-1.5.7.jar
MTLib-3.0.6.jar
mystcraft-1.12.2-0.13.7.04.jar
MysticalAgradditions-1.12.2-1.3.2.jar
MysticalAgriculture-1.12.2-1.7.5.jar
Neat 1.4-17.jar
NuclearCraft-2.17c-1.12.2.jar
ocxnetdriver-1.0.3-b17.jar
ogdragon-1.12.2-0.1.4.jar
OpenComputers-MC1.12.2-1.7.4.153.jar
OreExcavation-1.4.137.jar
Parabox-1.12.2-2.0.0.jar
Patchouli-1.0-19.jar
PickleTweaks-1.12.2-2.1.3.jar
PipeMaster-1.0.2-b8.jar
Placebo-1.12.2-1.6.0.jar
PlaneFix-1.12.2-1.0.0.jar
PortalGun-1.12.2-7.1.0.jar
practicallogistics2-1.12.2-3.0.8-11.jar
Prestige-1.12.2-1.1.58.jar
PrimitiveCrafting MC1.12.2 v1.3.5.jar
ProjectE-1.12.2-PE1.4.1.jar
ProportionalDestructionParticles-1.12.2-1.2.4.jar
rangedpumps-0.5.jar
realfilingcabinet-1.12-0.2.0.19.jar
reauth-3.6.0.jar
RecipeStages-1.1.3.jar
RedstoneFlux-1.12-2.1.0.6-universal.jar
ResourceHogs-1.12.2-1.0.12.jar
ResourceLoader-MC1.12.1-1.5.3.jar
rftoolspower-1.12-1.1.2.jar
rustic-1.0.15.jar
simplegenerators-1.12.2-2.0.20.2.jar
SimpleStorageNetwork-1.12.2-1.7.8.jar
SkyBonsais-1.0.1.jar
SkyGrid-1.1.7.jar
SkyOrchards-0.0.12.jar
Slab_Machines-1.0.6.jar
SlimyBoyos-1.0.0.jar
SmoothFont-mc1.12.2-2.1.jar
Snad-1.12.1-1.7.09.16a.jar
sonarcore-1.12.2-5.0.19-20.jar
SqueezerPatch-1.12.2-1.0.0.jar
statues-1.12.X-0.8.9.jar
stg-1.12.2-1.2.3.jar
StuffASockInIt-1.12.2-1.1.30.jar
supersoundmuffler-1.12.2-1.0.2.10.jar
Surge-1.12.2-2.0.77.jar
Sync-1.12.2-7.1.0.jar
TallGates-1.12.2-1.0.0.1.jar
TConstruct-1.12.2-2.12.0.157.jar
TelePastries-0.3.4.jar
tesla-core-lib-1.12.2-1.0.15.jar
ThermalDynamics-1.12.2-2.5.5.21-universal.jar
ThermalFoundation-1.12.2-2.6.3.27-universal.jar
ThermalInnovation-1.12.2-0.3.3.12-universal.jar
TinkersComplement-1.12.2-0.4.2.jar
TinkerToolLeveling-1.12.2-1.1.0.jar
tinyprogressions-1.12.2-3.3.34-Release.jar
TipTheScales-1.12.2-1.0.4.jar
Toast Control-1.12.2-1.8.1.jar
togetherforever-1.12.2-1.0.12-22.jar
tombstone-3.5.2-1.12.jar
Topography-1.12.2-1.10.1.jar
torchmaster_1.12.2-1.7.1.74.jar
Translocators-1.12.2-2.5.2.81-universal.jar
TreeGrowingSimulator2017-1.0.1.jar
Triumph-1.12.2-3.17.0.jar
twilightforest-1.12.2-3.8.689-universal.jar
Twitchcrumbs_1.12.2-3.0.4.jar
Uppers-0.0.6.jar
valkyrielib-1.12.2-2.0.20.1.jar
ViesCraft-1.12.2-5.9.13.jar
Waddles-1.12.2-0.6.0.jar
WailaStages-1.12.2-2.0.24.jar
walljump-1.12.2-1.2.3.jar
Wawla-1.12.2-2.5.273.jar
weirdinggadget-1.12.2-2.1.16-universal.jar
witherCrumbs-1.12.2-0.11.jar
WorldBook-1.0.0.jar
worldutils-1.12.2-0.4.2.jar
XCPatch-1.12.2-1.0.1.jar
XL-Food-Mod-1.12.2-1.9.1.jar
xnet-1.12-1.7.6.jar
YNot-0.2.3.jar
yoyos_1.12.2-1.3.3.25.jar
zenstages-0.4.1-19.jar
@sam-kirby
Copy link

sam-kirby commented Nov 15, 2019

Hi, I'm one of the maintainers of SevTech and SF4. This is not caused by Industrial Foregoing and whilst there may be a way for them to bypass firing the RightClickBlock event this will likely result in incompatibilities with other mods.

This is caused by Harvest firing the HarvestDropsEvent event before deciding whether a harvest will take place, I opened a pull request in July to resolve this but it has not attracted the attention of the author.

Ref: TehNut-Mods/Harvest#19 and TehNut-Mods/Harvest#16

@sam-kirby
Copy link

Ignore my above comment, you are right to say that Harvest is not in the pack - it's far too similar to the issue we had in SevTech though so it's possible whichever mod is handling crop right click to harvest might have the same error.

@sam-kirby
Copy link

Cause here is pickletweaks, it spawns item entities for the drops array before passing it to the HarvestDropsEvent.

@mpavkovic
Copy link
Author

Cause here is pickletweaks, it spawns item entities for the drops array before passing it to the HarvestDropsEvent.

Yup, can confirm! After I disabled right click to harvest in it's config B:right_click_harvest=false and enabled it through Ender Core which is in the pack B:allowCropRC=true, Plant Interactor is working fine. Although, I think crops added by other mods might have to be manually added to cropconfig.json. Anyway, thats an issue for SF4, I'll try to find a workaround.

Also, it has already been reported to Pickle Tweaks developers: BlakeBr0/PickleTweaks#33

You may close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants