Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect warranty expiration on Dell Laptop #136

Open
baderarvitis opened this issue May 7, 2024 · 3 comments
Open

Incorrect warranty expiration on Dell Laptop #136

baderarvitis opened this issue May 7, 2024 · 3 comments

Comments

@baderarvitis
Copy link

baderarvitis commented May 7, 2024

  • Version of the plugin : 3.0.8

  • Version of your GLPI : GLPI 10.0.15

  • Steps to reproduce (which actions have you made) :

Imports warranty informations for a Dell Laptop

  • Expected result :
    Correct match for the expiration of the warranty date

  • Actual result :
    Not the correct date of the expiration warranty

  • URL of the page :

  • Screenshot of the problem (if pertinent) :

image

image

@Samuel-Volant
Copy link

Hello !

I had a similar problem with the start of the warranty. Not sure if it's the same for you. (probably not)
One thing I found is that the "getStartDate" function from dell.class.php looked for the highest date instead of the lowest. (on Line 143)
I hope it helps someone. :)

Samuel

@Beufff
Copy link

Beufff commented Oct 22, 2024

Hi,
Have the same issue with the start date not being correct.
GLPI version : 10.0.16
SuplierImport version : 3.0.8

image

image

@Samuel-Volant
Copy link

Hi,

I opened a Pull request to correct the issue but i'm not to familiar with github so I don't know if I did good or not.
If you want to correct it yourself : In inc/dell.class.php at line 143 change
if ($max_date == false || $date > $max_date) {
to
if ($max_date == false || $date < $max_date) {

Hope this helps !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants