Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counting fees is missing when wallet is locked of the peer partner #7

Closed
M1ch43lV opened this issue Jan 26, 2024 · 2 comments
Closed

Comments

@M1ch43lV
Copy link

Hello Impalor! Thanks for the great tool, it helps a lot to have an overview of successful and unsuccessful swaps.
I have following suggestion for psweb:

  1. Cumulative fee statistics for all paid fees (successful and unsuccessful ones) on one page showing all fees occurred with date and time.psw
  2. Counting paid fees of unsuccessful swaps if possible. Example log which occurred with one of my peer partner whose wallet was locked:
    image
2024/01/26 09:20:07 [INFO] [Swap:8eaa42137d7dca61371a4d36cadb080b3c27531e1920e2eb1306bdafbb0255b8] Paid Feeinvoice of 306 sats
2024/01/26 09:20:07 [INFO] [Swap:8eaa42137d7dca61371a4d36cadb080b3c27531e1920e2eb1306bdafbb0255b8] Swap canceled. Reason: -13:Error: Please enter the wallet passphrase with walletpassphrase first.
2024/01/26 09:20:07 [INFO] [Swap:8eaa42137d7dca61371a4d36cadb080b3c27531e1920e2eb1306bdafbb0255b8] Warning: Paid swap-out prepayment, but swap canceled before receiving opening transaction```


@M1ch43lV M1ch43lV changed the title Counting fees missing when wallet locked of the peer partner Counting fees is missing when wallet is locked of the peer partner Jan 26, 2024
@Impa10r
Copy link
Owner

Impa10r commented Jan 26, 2024

Yes, I agree this would be useful, but the swaps statistics is done by peerswap. Web UI can merely display it. Currently, only lightning invoices are accounted for. There is an open issue to add chain fees to the recorded stats: ElementsProject/peerswap#266

@Impa10r Impa10r closed this as completed Jan 26, 2024
@Impa10r
Copy link
Owner

Impa10r commented Jan 26, 2024

Please mention the unreported prepaid fee example at the link above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants