Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filename for test version wrong on jsbench #13

Open
clopez opened this issue Apr 23, 2017 · 2 comments
Open

filename for test version wrong on jsbench #13

clopez opened this issue Apr 23, 2017 · 2 comments

Comments

@clopez
Copy link
Collaborator

clopez commented Apr 23, 2017

On the graph for jsbench (browser WebKitGTK+ MiniBrowser) https://browserperfdash.igalia.com/dash/graph/

The test version when hovering over a point appears as tar.gz. It should be instead jsbench-2013.1.tar.gz

You can use python's os.path.basename function to get this:

In [1]: import os
In [2]: version_full="http://plg.uwaterloo.ca/~dynjs/jsbench/suite/jsbench-2013.1.tar.gz"
In [3]: os.path.basename(version_full)
Out[3]: 'jsbench-2013.1.tar.gz'
@tonythomas01
Copy link
Collaborator

Looks good. Do you think that we should be only saving this basename in the db (like cut this thing off during bot data reception)?

Eitherway, I guess we would need a table drop.

@clopez
Copy link
Collaborator Author

clopez commented Jun 26, 2018

After inspecting this in more detail I see how the whole test_version is sent by the backend code in the json for the JS frontend code to build the graph.

Example of JSON sent:

[
  {
    "timestamp": "1529019948",
    "browser": "minibrowser-gtk",
    "mean_value": 25.1725950677547,
    "stddev": 0.0634808454379252,
    "browser_version": "r232847",
    "delta": 0,
    "bot": "webkitgtk-release-perf-64",
    "test_version": "http://plg.uwaterloo.ca/~dynjs/jsbench/suite/jsbench-2013.1.tar.gz"
  },
  {
    "timestamp": "1529091133",
    "browser": "minibrowser-gtk",
    "mean_value": 26.3150119065589,
    "stddev": 0.0378215489800925,
    "browser_version": "r232876",
    "delta": 4.34131226260042,
    "bot": "webkitgtk-release-perf-64",
    "test_version": "http://plg.uwaterloo.ca/~dynjs/jsbench/suite/jsbench-2013.1.tar.gz"
  }
[....]
]

So the fix should be in the fronted, to display the basename (all that goes after the last slash/ ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants