Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce redundancy of if c.DBChoice littered thoruhgout codebase #181

Closed
Ianleeclark opened this issue Dec 12, 2016 · 0 comments
Closed

Reduce redundancy of if c.DBChoice littered thoruhgout codebase #181

Ianleeclark opened this issue Dec 12, 2016 · 0 comments
Labels
Merged to Devel
Milestone
0.6.0 -- Improve ...

Comments

@Ianleeclark
Copy link
Owner

There just needs to be a database/database.go:OpenDBChoiceConnection() function that handles this. This will reduce imports throughout the codebase and reduce overall clutter found in the current origin/devel branch. This should be part of 0.6.0
@Ianleeclark Ianleeclark mentioned this issue Dec 12, 2016
Merged
7 tasks
Ianleeclark added a commit that referenced this issue Dec 12, 2016
@Ianleeclark
Issue #181
ffcafb0 
CHANGE:
  - Moved all `SQLStore` stuff into `database/impl/sqlstore.go`. All other
    changes are accompanying this.
  - server/server.go & reaper/reaper.go Now uses
    `database/impl/sqlstore.go:InitSQLStoreByDBChoice()` so that they don't
    need to be aware of individual implementations.
Ianleeclark added a commit that referenced this issue Dec 12, 2016
@Ianleeclark
Issue #181
f053ad6 
Merge branch 'devel' of ssh://github.com/GrappigPanda/notorious into issue-181
Ianleeclark added a commit that referenced this issue Dec 12, 2016
@Ianleeclark
Merge pull request #183 from GrappigPanda/issue-181
d8e9aec 
Fixes #181
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Merged to Devel
Projects
None yet
Milestone
0.6.0 -- Improve announcing
Development

No branches or pull requests
1 participant
@Ianleeclark