Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Redis to an interface #150

Closed
Ianleeclark opened this issue Oct 29, 2016 · 0 comments
Closed

Change Redis to an interface #150

Ianleeclark opened this issue Oct 29, 2016 · 0 comments
Labels
enhancement Merged to Devel Refactor
Milestone
0.5.0 -- Performa...

Comments

@Ianleeclark
Copy link
Owner

This will help in a following issue where we'll allow Olivia deployments to be the backend peer cache instead of Redis.
@Ianleeclark Ianleeclark mentioned this issue Oct 29, 2016
Open
Ianleeclark added a commit that referenced this issue Nov 22, 2016
@Ianleeclark
Issue #150
3273079 
CHANGE:
  - Moved all redis stuff into `./server/peerStore`
  - peerStore/redisStore.go Now creates connectiosn on-the-fly. This is a
    degradation for performance and shouldn't be necessary. However, I'm lazy
    and Redis is going to be trashed for Olivia. In the future, a better
    solution would be to send all redis operations to a central store and have
    that store process via one connection.
@Ianleeclark Ianleeclark mentioned this issue Nov 22, 2016
Closed
Ianleeclark added a commit that referenced this issue Nov 22, 2016
@Ianleeclark
Issue #150
bc80fec 
CHANGE:
  - server/peerStore/redis_test.go Importing `server` package, as we need the
    definitions from it.
Ianleeclark added a commit that referenced this issue Nov 25, 2016
@Ianleeclark
Issue #150
a879c23 
Major refactor of server/annoucne -> announce/announce.go
Ianleeclark added a commit that referenced this issue Nov 25, 2016
@Ianleeclark
Issue #150
b47e4b5 
CHANGE:
  - server/peerStore/peerstore.go Added a new method all peerStores should
    implement.
  - server/peerStore/redisStore.go Added new wrapper methods to implement the
    `PeerStore` interface.
  - server/server.go Still attempting to decouple heavily spaghettied code.
Ianleeclark added a commit that referenced this issue Nov 25, 2016
@Ianleeclark
Issue #150
790826d 
CHANGE:
  - kvStoreInterfaces/redis.go Now houses common redis calls used
    **throughout** the application. The `server/peerStore/redisStore.go` file
    just implements a wrapper around these.
@Ianleeclark Ianleeclark mentioned this issue Nov 25, 2016
Merged
12 tasks
@Ianleeclark Ianleeclark mentioned this issue Nov 27, 2016
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Merged to Devel Refactor
Projects
None yet
Milestone
0.5.0 -- Performance improvements
Development

No branches or pull requests
1 participant
@Ianleeclark