Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a connection pooler for MySQL #125

Closed
Ianleeclark opened this issue May 4, 2016 · 1 comment
Closed

Create a connection pooler for MySQL #125

Ianleeclark opened this issue May 4, 2016 · 1 comment
Assignees
@Ianleeclark
Labels
Feature Merged to Devel
Milestone
0.5.0 -- Performa...

Comments

@Ianleeclark
Copy link
Owner

Right now with how we connect to MySQL, we open a connection per transaction. It'd be wiser if I created a connection pooler which would hold N open connections and make requests on-demand.

This would cut down on SQL transaction time because we wouldn't have to worry about the overhead in opening a connection every transaction.
@Ianleeclark Ianleeclark self-assigned this May 4, 2016
@Ianleeclark Ianleeclark mentioned this issue May 20, 2016
Merged
10 tasks
@Ianleeclark
Copy link
Owner Author

The sql.DB interface implements a connection pool by itself, so I ought to either share that in the applicaionContext or allow each request to borrow a connection from the connection pool.

@Ianleeclark Ianleeclark reopened this Jun 19, 2016
@Ianleeclark Ianleeclark mentioned this issue Nov 25, 2016
Merged
12 tasks
Ianleeclark added a commit that referenced this issue Nov 27, 2016
@Ianleeclark
Issue #125
2cd3385 
CHANGE:
  - database/database.go Updating some comments.
  - server/server.go Added a curried `scrapeHandler` which uses a database
    pool.
Ianleeclark added a commit that referenced this issue Nov 27, 2016
@Ianleeclark
Issue #125
0c843b3 
ADD:
  - database/database.go:assertOpenConnection() now asserts a passed in
    connection object is not nil, if it is nil then we will open a new
    connection. This massively cuts down on opening/closing of connections
    during runtime vs initialization.

CHANGE:
  - reaper/reaper.go Updating for changes in `database/database.go`. See `ADD`
    section.
  - server/server.go Added a `dbPool` object to the `applicationContext` and
    updated for changes in `database/database.go`.
Ianleeclark added a commit that referenced this issue Nov 27, 2016
@Ianleeclark
Issue #125
cefdbcb 
Resolving build failures.
@Ianleeclark Ianleeclark mentioned this issue Nov 27, 2016
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ianleeclark Ianleeclark

Labels
Feature Merged to Devel
Projects
None yet
Milestone
0.5.0 -- Performance improvements
Development

No branches or pull requests
1 participant
@Ianleeclark