Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 expose listing license checkouts for frontend #6987

Merged
merged 15 commits into from
Jan 6, 2025
Merged

🎨 expose listing license checkouts for frontend #6987

merged 15 commits into from
Jan 6, 2025

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Dec 20, 2024 •
edited
Loading

@matusdrobuliak66 matusdrobuliak66 self-assigned this Dec 20, 2024
@matusdrobuliak66 matusdrobuliak66 added the a:webserver issue related to the webserver service label Dec 20, 2024
@matusdrobuliak66 matusdrobuliak66 added this to the Event Horizon milestone Dec 20, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.31933% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.74%. Comparing base (300e242) to head (104e42e).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6987      +/-   ##
==========================================
- Coverage   86.99%   86.74%   -0.25%     
==========================================
  Files        1621     1467     -154     
  Lines       64052    60768    -3284     
  Branches     2035     1646     -389     
==========================================
- Hits        55723    52716    -3007     
+ Misses       7995     7782     -213     
+ Partials      334      270      -64
Flag Coverage Δ
integrationtests 64.84% <67.32%> (+0.92%) ⬆️
unittests 85.09% <98.31%> (-0.21%) ⬇️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.58% <100.00%> (+0.02%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.02% <ø> (ø)
pkg_service_library 73.30% <0.00%> (+0.07%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.38% <ø> (ø)
agent 96.82% <ø> (ø)
api_server 90.13% <ø> (ø)
autoscaling 96.09% <ø> (ø)
catalog 90.57% <ø> (ø)
clusters_keeper 99.48% <ø> (ø)
dask_sidecar 91.26% <ø> (ø)
datcore_adapter 93.18% <ø> (ø)
director 76.40% <ø> (-0.09%) ⬇️
director_v2 91.41% <ø> (+0.02%) ⬆️
dynamic_scheduler 97.19% <ø> (ø)
dynamic_sidecar 89.75% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.44% <ø> (ø)
osparc_gateway_server ∅ <ø> (∅)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.56% <ø> (ø)
storage 89.54% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 84.16% <100.00%> (-0.21%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300e242...104e42e. Read the comment docs.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review December 20, 2024 14:15
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) December 20, 2024 14:39
pcrespov
pcrespov reviewed Jan 3, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a badge to show new openapi specs in the description :-)
It is easy and a good practice

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) January 6, 2025 12:13
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

odeimaiz
odeimaiz reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@matusdrobuliak66 matusdrobuliak66 merged commit 61a78bc into ITISFoundation:master Jan 6, 2025
92 of 93 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the introduce-vip-models-pricing-9-part branch January 6, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeimaiz odeimaiz odeimaiz left review comments

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@GitHK GitHK GitHK approved these changes

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels
a:webserver issue related to the webserver service
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
6 participants
@matusdrobuliak66 @giancarloromeo @GitHK @pcrespov @odeimaiz @sanderegg