🐛🎨♻️Director-v0: improve registry caching #6799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6799 +/- ##
==========================================
+ Coverage 88.40% 89.83% +1.43%
==========================================
Files 1545 1102 -443
Lines 61634 47971 -13663
Branches 2155 410 -1745
==========================================
- Hits 54488 43097 -11391
+ Misses 6818 4804 -2014
+ Partials 328 70 -258
Continue to review full report in Codecov by Sentry.
|
pcrespov
approved these changes
Nov 21, 2024
| timeout=timeout_settings, | ||
| json_serialize=json_dumps, | ||
| ) | ||
| session = httpx.AsyncClient(transport=httpx.AsyncHTTPTransport(http2=True)) |
There was a problem hiding this comment.
well it does not reject it so why not use it?
services/director/src/simcore_service_director/registry_proxy.py
Outdated
Show resolved
Hide resolved
services/director/src/simcore_service_director/registry_proxy.py
Outdated
Show resolved
Hide resolved
GitHK
reviewed
Nov 22, 2024
GitHK
approved these changes
Nov 22, 2024
|
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Since director-v0 was updated, the home-made caching mechanism was replaced by aiocache.
This lead to a difference in behavior, as the home-made caching was running independently of Rest API calls and would pre-build the cache before any other client would list services.
So the current situation is that the first call to the director /services takes a long time until it gets cached properly.
This PR brings:
Related issue/s
How to test
Dev-ops checklist