Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️Migration: Storage #6599

Merged
merged 41 commits into from
Oct 25, 2024
Merged

⬆️Migration: Storage #6599

merged 41 commits into from
Oct 25, 2024

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 24, 2024 •
edited
Loading

What do these changes do?

  • migrate storage to pydantic V2
  • fixed json_serialization to understand new pydantic v2 Url type
  • Removed AnyUrlLegacy and replaced with standard pydantic v2 AnyUrl type

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:storage issue related to storage service label Oct 24, 2024
@sanderegg sanderegg added this to the MartinKippenberger milestone Oct 24, 2024
@sanderegg sanderegg self-assigned this Oct 24, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.7%. Comparing base (fb48eb1) to head (0f9d6a0).
Report is 2 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Files with missing lines Patch % Lines
...service_storage/datcore_adapter/datcore_adapter.py 25.0% 3 Missing ⚠️
...rage/src/simcore_service_storage/simcore_s3_dsm.py 72.7% 3 Missing ⚠️
...es/storage/src/simcore_service_storage/settings.py 87.5% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                              Coverage Diff                              @@
##           pydantic_v2_migration_do_not_squash_updates   #6599     +/-   ##
=============================================================================
+ Coverage                                         80.9%   82.7%   +1.7%     
=============================================================================
  Files                                              289     301     +12     
  Lines                                            10605   12212   +1607     
  Branches                                           346     164    -182     
=============================================================================
+ Hits                                              8584   10102   +1518     
- Misses                                            1975    2084    +109     
+ Partials                                            46      26     -20
Flag Coverage Δ
unittests 82.7% <91.1%> (+1.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../src/common_library/pydantic_networks_extension.py 100.0% <100.0%> (ø)
...rvice_dask_sidecar/computational_sidecar/models.py 95.9% <100.0%> (+<0.1%) ⬆️
...storage/src/simcore_service_storage/application.py 84.4% <ø> (ø)
...torage/datcore_adapter/datcore_adapter_settings.py 100.0% <100.0%> (ø)
...e/src/simcore_service_storage/db_file_meta_data.py 98.5% <100.0%> (ø)
...storage/src/simcore_service_storage/db_projects.py 100.0% <100.0%> (ø)
.../storage/src/simcore_service_storage/exceptions.py 100.0% <100.0%> (ø)
...e/src/simcore_service_storage/handlers_datasets.py 100.0% <ø> (ø)
...rage/src/simcore_service_storage/handlers_files.py 99.2% <100.0%> (ø)
...age/src/simcore_service_storage/handlers_health.py 100.0% <100.0%> (ø)
... and 8 more

... and 135 files with indirect coverage changes

matusdrobuliak66
matusdrobuliak66 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

giancarloromeo
giancarloromeo reviewed Oct 25, 2024
View reviewed changes
packages/models-library/src/models_library/api_schemas_storage.py
@@ -149,7 +153,7 @@ class FileMetaDataGet(BaseModel):
)

model_config = ConfigDict(
extra="forbid",
extra="ignore",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he is ignoring it ;-b

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giancarloromeo yes. that is what I wrote to you in the chat yesterday.

pcrespov
pcrespov approved these changes Oct 25, 2024
View reviewed changes
packages/models-library/src/models_library/api_schemas_storage.py
@@ -149,7 +153,7 @@ class FileMetaDataGet(BaseModel):
)

model_config = ConfigDict(
extra="forbid",
extra="ignore",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he is ignoring it ;-b

@sanderegg sanderegg merged commit 7410516 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Oct 25, 2024
28 of 58 checks passed
@sanderegg sanderegg deleted the migration/storage branch October 25, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@sanderegg sanderegg

Labels
a:storage issue related to storage service
Projects
None yet
Milestone
MartinKippenberger
Development

Successfully merging this pull request may close these issues.
4 participants
@sanderegg @giancarloromeo @pcrespov @matusdrobuliak66