Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend does not display correctly error message with 5XX #6503

Closed
1 task done
pcrespov opened this issue Oct 8, 2024 · 1 comment
Closed
1 task done

Frontend does not display correctly error message with 5XX #6503

pcrespov opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
bug buggy, it does not work as expected

Comments

@pcrespov
Copy link
Member

pcrespov commented Oct 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Which deploy/s?

development (master)

Current Behavior

ON a 5XX response, the front-end does nto display the error message in the respons

Expected Behavior

On a 5XX response, if there is an error message in the response, it should be shown, otherwise use a default message

Steps To Reproduce

In order to reproduce an unexpected error, build and local, checkout master on commit 997eeb3

  1. git checkout 997eeb3129754d3295ddbca13afb788f78386a31
  2. make build
  3. make up-prod
  4. in the db select a product (e.g. osparc)
  5. remove the groups_extra_properties row associated to that product -> this will make the configuration invalid and in this commit this error was not handled correctly.
  6. try to login
  7. it will fail displaying a strange message

image

Anything else?

From #6432, the response is standard

I did a reference to it in #6485 (review) as well.

@pcrespov pcrespov added the bug buggy, it does not work as expected label Oct 8, 2024
@pcrespov pcrespov added this to the MartinKippenberger milestone Oct 8, 2024
@odeimaiz
Copy link
Member

Fixed in master
ErrorMessage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected
Projects
None yet
Development

No branches or pull requests

4 participants