diff --git a/.github/workflows/ci-testing-deploy.yml b/.github/workflows/ci-testing-deploy.yml index 4d4aa42c13b..86633d0b3c8 100644 --- a/.github/workflows/ci-testing-deploy.yml +++ b/.github/workflows/ci-testing-deploy.yml @@ -1439,42 +1439,6 @@ jobs: with: token: ${{ secrets.CODECOV_TOKEN }} - unit-test-frontend: - needs: changes - if: ${{ needs.changes.outputs.static-webserver == 'true' || github.event_name == 'push' }} - timeout-minutes: 18 # if this timeout gets too small, then split the tests - name: "[unit] frontend" - runs-on: ${{ matrix.os }} - strategy: - matrix: - node: [14] - os: [ubuntu-22.04] - fail-fast: false - steps: - - uses: actions/checkout@v4 - - name: setup docker buildx - id: buildx - uses: docker/setup-buildx-action@v3 - with: - driver: docker-container - - uses: actions/setup-node@v4.0.4 - with: - node-version: ${{ matrix.node }} - cache: "npm" - - name: install uv - uses: yezz123/setup-uv@v4 - - uses: actions/cache@v4 - id: cache-uv - with: - path: ~/.cache/uv - key: ${{ runner.os }}-${{ github.job }}-python-${{ matrix.python }}-uv - - name: show system version - run: ./ci/helpers/show_system_versions.bash - - name: install - run: ./ci/github/unit-testing/frontend.bash install - - name: test - run: ./ci/github/unit-testing/frontend.bash test - unit-test-python-linting: needs: changes if: ${{ needs.changes.outputs.anything-py == 'true' || github.event_name == 'push' }} @@ -1927,7 +1891,6 @@ jobs: unit-test-director, unit-test-dynamic-sidecar, unit-test-efs-guardian, - unit-test-frontend, unit-test-models-library, unit-test-notifications-library, unit-test-osparc-gateway-server, diff --git a/ci/github/unit-testing/frontend.bash b/ci/github/unit-testing/frontend.bash deleted file mode 100755 index cffd77cf64a..00000000000 --- a/ci/github/unit-testing/frontend.bash +++ /dev/null @@ -1,74 +0,0 @@ -#!/bin/bash -# http://redsymbol.net/articles/unofficial-bash-strict-mode/ -set -o errexit # abort on nonzero exitstatus -set -o nounset # abort on unbound variable -set -o pipefail # don't hide errors within pipes -IFS=$'\n\t' - -install() { - npm install - make -C services/static-webserver/client clean - npx eslint --version - make -C services/static-webserver/client info -} - -test() { - echo "# Running Linter" - npm run linter - - pushd services/static-webserver/client - - echo "# Building build version" - make compile - - echo "# Building source version" - make compile-dev flags=--machine-readable - - echo "# Serving source version" - make serve-dev flags="--machine-readable --target=source --listen-port=8080" detached=test-server - - #TODO: move this inside qx-kit container - echo "# Waiting for build to complete" - while ! nc -z localhost 8080; do - sleep 1 # wait for 10 second before check again - done - - # FIXME: reports ERROR ReferenceError: URL is not defined. See https://github.com/ITISFoundation/osparc-simcore/issues/1071 - ## node source-output/resource/qxl/testtapper/run.js --diag --verbose http://localhost:8080/testtapper - wget --spider http://localhost:8080/ - - make clean - popd - - #TODO: no idea what is this doing... disabled at the moment since travis is supposed to do it as well - - # # prepare documentation site ... - # git clone --depth 1 https://github.com/ITISFoundation/itisfoundation.github.io.git - # rm -rf itisfoundation.github.io/.git - - # # if we have old cruft hanging around, we should remove all this will - # # only trigger once - # if [ -d itisfoundation.github.io/transpiled ]; then - # rm -rf itisfoundation.github.io/* - # fi - - # # add the default homepage - # cp -rp docs/webdocroot/* itisfoundation.github.io - - # # add our build - # if [ -d services/static-webserver/client/build-output ]; then - # rm -rf itisfoundation.github.io/frontend - # cp -rp services/static-webserver/client/build-output itisfoundation.github.io/frontend - # fi -} - -# Check if the function exists (bash specific) -if declare -f "$1" > /dev/null -then - # call arguments verbatim - "$@" -else - # Show a helpful error - echo "'$1' is not a known function name" >&2 - exit 1 -fi