📝 Update PULL_REQUEST_TEMPLATE.md with instructions for internal devs #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
I am ok-ish with this type of doc but IMO the most effective way to learn about these rules is simply during the PR reviews. Moreover, this might change easily with time ... for instance if we notice we do not use labels, etc ...
As an example: you will probably not forget about the items you enumerate since we were doing fun of it during lunch today, right ? :-)
Another one for the list if you wish : remove WIP from the title when you submit a PR to review ;-b
wvangeit
changed the title
bisgaard-itis
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Add instruction for internal devs to add labels to the PR etc.
Related issue/s
How to test
Read the new template