Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the instrument schema to make the list of collimators a part of detector objects #68

Open
TimofeiZavileiskii opened this issue Jul 28, 2022 · 0 comments

Comments

@TimofeiZavileiskii
Copy link
Collaborator

TimofeiZavileiskii commented Jul 28, 2022

Change the instrument schema to instead of having a list of collimators as a part of the instrument, make it part of a detector object.

Right now the collimator has the detector it is attached to as a string inside it, allowing to have collimators with the same name if they are attached to different detectors. It would be more logical if instead collimators would be a part of the detector object they are attached to like links and joints are a part of the positioner object.

It would require:

  • Update how the Json files are processed into an instrument
  • Implement backwards compatibility to be able to read and convert files of old schema into the new one
  • Update documentation about the Instrument Schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants