Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service & Manager: Add more unit tests #11

Open
mihai-stfc opened this issue Jun 2, 2021 · 1 comment
Open

Service & Manager: Add more unit tests #11

mihai-stfc opened this issue Jun 2, 2021 · 1 comment
Labels
Manager Ticket concerning the HLM PV Import Service Manager Service Ticket concerning the HLM PV Import Service

Comments

@mihai-stfc
Copy link
Collaborator

At the moment, the service is lacking testing for some of the code that has been refactored, while the manager has none.

To-do:

  1. Find out what tests would be useful for the service and write them (e.g. DB functions etc.).
  2. The manager currently has no tests, try adding unit tests where possible

Notes:

  • a coverage checker should help with finding out where there are missing tests
@mihai-stfc mihai-stfc added Manager Ticket concerning the HLM PV Import Service Manager Service Ticket concerning the HLM PV Import Service labels Jul 5, 2021
@LowriJenkins
Copy link
Contributor

More testing likely still nesecary so will leave this issue open.
The manager now has much more unit testing, and coverage has been added to the project.
total coverage = approximatly 82%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manager Ticket concerning the HLM PV Import Service Manager Service Ticket concerning the HLM PV Import Service
Projects
None yet
Development

No branches or pull requests

2 participants