Remove terminal icon from Workbench page #458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.pre-commit-config.yaml
Outdated
| @@ -45,23 +45,23 @@ repos: | |||
| # stages: [pre-push] | |||
|
|
|||
| - repo: https://github.com/pre-commit/mirrors-prettier | |||
| rev: v3.1.0 | |||
| rev: v4.0.0-alpha.8 | |||
There was a problem hiding this comment.
please select a stage version if it is available.
.pre-commit-config.yaml
Outdated
| hooks: | ||
| - id: eslint | ||
| args: ["--fix"] | ||
| files: "^(client|servers/execution/runner|servers/lib)/.*" | ||
| stages: [pre-commit] | ||
|
|
||
| - repo: https://github.com/igorshubovych/markdownlint-cli | ||
| rev: v0.37.0 | ||
| rev: v0.38.0 |
There was a problem hiding this comment.
something like this
.pre-commit-config.yaml
Outdated
| hooks: | ||
| - id: prettier | ||
| args: ["--ignore-path", "../.gitignore", "--write"] | ||
| files: '^(client|servers/execution/runner|servers/lib)/.*\.(ts|tsx|css|scss)$' | ||
| stages: [pre-commit] | ||
|
|
||
| - repo: https://github.com/pre-commit/mirrors-eslint | ||
| rev: v8.54.0 | ||
| rev: v9.0.0-alpha.1 |
There was a problem hiding this comment.
please select a stage version if it is available
client/config/dev.js
Outdated
| @@ -5,7 +5,7 @@ if (typeof window !== 'undefined') { | |||
| REACT_APP_URL_BASENAME: 'dtaas', | |||
| REACT_APP_URL_DTLINK: '/lab', | |||
| REACT_APP_URL_LIBLINK: '', | |||
| REACT_APP_WORKBENCHLINK_TERMINAL: '/terminals/main', | |||
| // REACT_APP_WORKBENCHLINK_TERMINAL: '/terminals/main', | |||
There was a problem hiding this comment.
you can remove this line in all the config files
| @@ -0,0 +1,10 @@ | |||
| INFO Accepting connections at http://localhost:4000 | |||
There was a problem hiding this comment.
please do not add this file
| @@ -1,5 +1,5 @@ | |||
| import * as React from 'react'; | |||
| import TerminalOutlinedIcon from '@mui/icons-material/TerminalOutlined'; | |||
| // import TerminalOutlinedIcon from '@mui/icons-material/TerminalOutlined'; | |||
There was a problem hiding this comment.
please remove the commented lines
|
@aryanbhosale Thanks for the PR. Please fix the failing tests. |
|
Code Climate has analyzed commit 186f0ed and detected 0 issues on this pull request. View more on Code Climate. |
|
PR #459 addresses the same issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.