Validates client config #1083
Draft
Validates client config #1083
+400
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@atomicgamedeveloper thanks for the PR. Please check the comments.
…cgamedeveloper/DTaaS into 658-validate-client-config
| @@ -90,7 +90,8 @@ | |||
| "resize-observer-polyfill": "^1.5.1", | |||
| "serve": "^14.2.1", | |||
| "styled-components": "^6.1.1", | |||
| "typescript": "5.1.6" | |||
| "typescript": "5.1.6", | |||
| "zod": "^3.23.8" | |||
There was a problem hiding this comment.
@atomicgamedeveloper
Is this used? Overall, it is better to move the config verification logic into util/config.ts. The zod can be used there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Validates client config.
Fixes #658
Type of Change
Description
This PR will provide a route to validate the client config file. A comprehensive, manual one for developers, and another one that automatically redirects users in case their config is incorrectly setup or URLs are unreachable.
It will also update the client dependencies. Related to issue #658.
Testing
Manual testing for now.
Impact
Additional Information
None.
Checklist
existing code.