Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IACS validator - Which GEMET concept URI to use? #1115

Open
fxprunayre opened this issue Sep 20, 2024 · 4 comments
Open

IACS validator - Which GEMET concept URI to use? #1115

fxprunayre opened this issue Sep 20, 2024 · 4 comments
Assignees
Labels
ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing
Milestone

Comments

@fxprunayre
Copy link

In the test related to IACS Dataset keyword > keyword GEMET value
cf. https://github.com/inspire-eu-validation/ets-repository/blob/v2024.2/metadata/2.0/datasets-and-series/ets-md-iacs-bsxets.xml#L247

A record with an Anchor like the following:

<gmx:Anchor xlink:href="http://www.eionet.europa.eu/gemet/concept/1600">politique agricole commune</gmx:Anchor>

is invalid.

image

A record with

<gco:CharacterString>Common Agricultural Policy</gco:CharacterString>

or

<gmx:Anchor xlink:href="http://www.eionet.europa.eu/gemet/en/concept/1600">politique agricole commune</gmx:Anchor>

is valid.

"Common Agricultural Policy" correspond to https://www.eionet.europa.eu/gemet/en/concept/1600 where the "Concept URL: http://www.eionet.europa.eu/gemet/concept/1600"

Should the concept URL be as defined in GEMET website or a specific URL containing the language code en?

image

Looking forward your advice

@fabiovinci
Copy link
Collaborator

Dear @fxprunayre,

thanks for opening the issue.

Following the rule we are using for the INSPIRE codelists, the correct value should indeed be the "Concept URL" that should act as an identifier.

We will conduct an internal review of the issue and get back to you.

@fabiovinci
Copy link
Collaborator

Dear @fxprunayre,

we analyzed the issue and decided to accept the "Concept URL" as valid.
We will retain the current URL (https://www.eionet.europa.eu/gemet/en/concept/1600) to ensure compatibility with the existing implementations.

@fabiovinci fabiovinci moved this from To do to In progress in Validator issues Oct 29, 2024
fabiovinci added a commit to inspire-eu-validation/metadata that referenced this issue Oct 29, 2024
The URL of the "Common Agricultural Policy" keyword has been changed to http://www.eionet.europa.eu/gemet/concept/1600, according to the helpdesk issue INSPIRE-MIF/helpdesk-validator#1115
@fabiovinci fabiovinci removed their assignment Oct 29, 2024
fabiovinci added a commit that referenced this issue Oct 29, 2024
The URLs of the "Common Agricultural Policy" keyword and other GEMET keywords have been changed to their respective Concept URL (e.g. from https://www.eionet.europa.eu/gemet/en/concept/1600 to http://www.eionet.europa.eu/gemet/concept/1600). Reference helpdesk issue #1115
@fabiovinci
Copy link
Collaborator

Dear @fxprunayre,

the issue has been resolved and is now ready for testing in the staging instance.

Could you please check it out and provide us with your feedback?

@fabiovinci fabiovinci assigned fxprunayre and unassigned dperezBM Nov 7, 2024
@fabiovinci fabiovinci added ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing and removed under development labels Nov 7, 2024
@fxprunayre
Copy link
Author

Thanks, we will give a try with @marceaulouis

@fabiovinci fabiovinci added this to the v2025.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for testing Solution provided to reporter or developed & deployed in staging (or beta), waiting for testing
Projects
Status: Staging: for acceptance
Development

No branches or pull requests

3 participants