review: feat: read jvm version for default compliance level #6043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinWitt
changed the title
|
I think that's indeed a better default, but it's probably something we want to at least highlight in the next release? I also don't think we need to catch any exception around the version code, as it should work on Java 10 onwards and we're targeting Java 17. |
Hmm, we could start collecting common answers and important behaviors on the website. |
Good idea. But maybe we can also improve the in-code documentation (e.g. add a comment to the |
SirYwell
reviewed
Nov 3, 2024
Co-authored-by: Hannes Greule <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe the current JVM version is a better default compared to 8 or?