-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update dependency org.eclipse.jdt:org.eclipse.jdt.core to v3.39.0 #5977
build(deps): update dependency org.eclipse.jdt:org.eclipse.jdt.core to v3.39.0 #5977
Conversation
It looks like JDT dropped support for targeting Java 1.7. So the minimum compliance level must be 8 now. |
2e8d1a4
to
3ff11be
Compare
72dcbaa
to
d340d1d
Compare
0478fb2
to
0805859
Compare
public class Action<Request extends BroadcastRequest<Request>, ShardRequest> {
private final Request request;
protected void performOperation(final int shardIndex) {
ShardRequest shardRequest = newShardRequest(request);
shardRequest.setParentTask(foobar);
}
} This is MWE for the failing stackoverflow test. The new version of JDT does not have a variable binding for the
I am not sure if this can reasonably be construed a JDT bug. There is basically nothing valid left in the code, though the connection to the variable feels quite easy to make… |
fd468a2
to
925b613
Compare
925b613
to
a8200f5
Compare
@I-Al-Istannen I had a look at the issue. It seems this will be fixed in 3.40? |
@MartinWitt Sounded like it :) |
Hmm we could mark the failing testcases as ignored and accept the regression? Otherwise, we would need to wait till January? |
We could use @GithubIssue (and reference this PR?) with |
Ah yes this is way better. |
Okay some random changes later everything is green |
Neat. Then I guess we can merge this. I will do that tomorrow, or you can do it before :P |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
3.38.0
->3.39.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.