Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependency org.eclipse.jdt:org.eclipse.jdt.core to v3.39.0 #5977

Merged
merged 5 commits into from
Oct 27, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 10, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.eclipse.jdt:org.eclipse.jdt.core (source) 3.38.0 -> 3.39.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@SirYwell
Copy link
Collaborator

It looks like JDT dropped support for targeting Java 1.7. So the minimum compliance level must be 8 now.

@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch 3 times, most recently from 2e8d1a4 to 3ff11be Compare October 8, 2024 09:07
@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch 9 times, most recently from 72dcbaa to d340d1d Compare October 8, 2024 13:37
@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch 15 times, most recently from 0478fb2 to 0805859 Compare October 9, 2024 16:52
@I-Al-Istannen
Copy link
Collaborator

public class Action<Request extends BroadcastRequest<Request>, ShardRequest> {
    private final Request request;
    protected void performOperation(final int shardIndex) {
        ShardRequest shardRequest = newShardRequest(request);
        shardRequest.setParentTask(foobar);
    }
}

This is MWE for the failing stackoverflow test. The new version of JDT does not have a variable binding for the setParentTask method call, as it does not seem to find the definition of the local variable.
Prerequisites:

  • Request is a recursive generic
  • request is passed to newShardRequest
  • The input of setParentTask is an undefined variable (otherwise the declaring type resolves to null even in older JDT versions)

I am not sure if this can reasonably be construed a JDT bug. There is basically nothing valid left in the code, though the connection to the variable feels quite easy to make…

@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch 12 times, most recently from fd468a2 to 925b613 Compare October 26, 2024 19:50
@renovate renovate bot force-pushed the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch from 925b613 to a8200f5 Compare October 26, 2024 19:56
@MartinWitt
Copy link
Collaborator

@I-Al-Istannen I had a look at the issue. It seems this will be fixed in 3.40?

@I-Al-Istannen
Copy link
Collaborator

@MartinWitt Sounded like it :)

@MartinWitt
Copy link
Collaborator

Hmm we could mark the failing testcases as ignored and accept the regression? Otherwise, we would need to wait till January?

@I-Al-Istannen
Copy link
Collaborator

I-Al-Istannen commented Oct 27, 2024

We could use @GithubIssue (and reference this PR?) with fixed=false? This way it will automatically fail in the next bump PR, if it were to be fixed.

@MartinWitt
Copy link
Collaborator

Ah yes this is way better.

@MartinWitt
Copy link
Collaborator

Okay some random changes later everything is green

@I-Al-Istannen
Copy link
Collaborator

Neat. Then I guess we can merge this. I will do that tomorrow, or you can do it before :P

Copy link
Contributor Author

renovate bot commented Oct 27, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@MartinWitt MartinWitt merged commit 2131800 into master Oct 27, 2024
14 checks passed
@MartinWitt MartinWitt deleted the renovate/org.eclipse.jdt-org.eclipse.jdt.core-3.x branch October 27, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants