-
-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spotless for imports #5741
Comments
We need to add
Any wishes for the order? |
I don't care as long as IJ can follow the same order and I don't need to run spotless :^) |
Can we please add a good-first-issue label here? We can then ask new contributors to work on this :) |
done |
Hello, I would like to try to contribute on this issue. I noticed that Spotless is applied to the files included in I suggest also to add I guess it is better to do a PR only about the |
Hi @micka-lama ! We would want to be similar to IJ style guide. @I-Al-Istannen do you use the formatted in IJ with default configurations? We could then configure spotless accordingly. |
Yea, just the defaults (except forbidding star imports). static imports are split and placed after the normal imports:
|
@micka-lama we look forward to your PR that configures spotless following two rules:
|
Currently, our import ordering in spoon is a bit messy. This leads to an unpleasant time with IntelliJ trying to sort the imports in a more normal order. Why don't we use spotless-maven-plugin to sort all our imports in a fixed sorting? This also helps to reduce diffs in the future for PRs. The benefit compared to checkstyle is that we can do the sorting automatic. See https://github.com/diffplug/spotless/tree/main/plugin-maven#java for an example.
The text was updated successfully, but these errors were encountered: