-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create digest page from Wireframe #86
Comments
Status:
The problem with the widget areas is as described in #77 (comment):
The expectation was that we'd be able to use existing Largo functionality to create a named widget area and output it only on this page. Instead, that named widget area is not output upon the page. It is not known why this is the case. Our options are:
1 has an unknown amount of time. 2 makes things weird in a way that might confuse the client, but shouldn't take more than an hour. |
I thought we had decided to hardcode it given the difficulty, so let's go ahead with that. |
@MirandaEcho I'm guessing that we should add some padding to these textwidgets? |
@benlk - yes please. We didn't budget any fancy styling, but some basic cleanup would be good. Lets remove the border and make the button match the other button in the sidebar, at least. Also, what's up with the description/title for the subscribe widget and all that extra text there? |
In that screenshot, I used a Ninja Forms widget. The extra text is what the widget was configured to output. We should ask them if they're using Ninja Forms for the mailchimp signups now rather than the ENN Mailchimp Subscribe widget we built them. |
The default style of the widget is to have padding and border; it looks like Largo removes the padding at certain viewport sizes: The theme contains a style that removes the borders when the widget has the "Reverse" background class applied, so not removing the border here is more-respecting of the existing styles. |
There's CSS being injected via the Customizer that makes the Ninja Forms button wider than the column on some screen sizes: #nf-field-33 {
padding: 0.75em 2.3em;
margin: 16px 0 0 0;
} And a lot of other CSS affecting the Ninja Form. Here's where I ended up at on Desktop: And on Mobile: These changes try not to have an adverse effect on the article pages, which have different layouts for that text. But the fact of the matter is, the Ninja Forms widget has weird markup that makes it hard to guarantee that the |
ENN Digest Page Wireframe (1).pdf
The text was updated successfully, but these errors were encountered: