Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a third custom sidebar for Spanish posts #95

Open
MirandaEcho opened this issue Apr 17, 2020 · 9 comments
Open

Create a third custom sidebar for Spanish posts #95

MirandaEcho opened this issue Apr 17, 2020 · 9 comments
Labels
Milestone

Comments

@MirandaEcho
Copy link
Collaborator

No description provided.

@benlk
Copy link
Collaborator

benlk commented Apr 29, 2020

This should be doable by creating the sidebar in Largo's options, or by using https://wpml.org/documentation/getting-started-guide/translating-widgets/

@benlk
Copy link
Collaborator

benlk commented May 7, 2020

Alternative: put all the single-post widgets in the same sidebar, but control which ones show up by the language selector https://wpml.org/documentation/getting-started-guide/translating-widgets/displaying-different-widgets-for-different-languages/

This would require 0 additional dev hours.

@benlk benlk added the Type: Question Further information is requested label May 7, 2020
@benlk
Copy link
Collaborator

benlk commented Jun 26, 2020

Question: Is the language selector sufficient for this purpose?

@MirandaEcho
Copy link
Collaborator Author

I'll need more information to answer that question. Does the language selector create a Spanish version of the sidebar on posts?

@benlk
Copy link
Collaborator

benlk commented Jul 1, 2020

It does not create a separate Spanish-specific sidebar. Rather, it allows certain widgets to be shown only in particular languages, so that the the post sidebar will contain English and Spanish widgets, but only English or Spanish widgets will be displayed on a post.

This also applies to #94

@MirandaEcho
Copy link
Collaborator Author

Requirement: When a user of the site clicks over to the Spanish version of the homepage, and then clicks into a Spanish version of an article, the sidebar content will be in Spanish without having to click on another "English/Spanish" toggle.

@benlk If this meets that requirement, then this works!

@benlk
Copy link
Collaborator

benlk commented Jul 2, 2020

I believe this meets that requirement. We can provide them the docs at https://wpml.org/documentation/getting-started-guide/translating-widgets/displaying-different-widgets-for-different-languages/ for them to test to make sure.

@benlk
Copy link
Collaborator

benlk commented Jul 2, 2020

Following on #94, all other widget areas have been translated, and I've duplicated the newsletter signup Gravity Form to translate that as well.

@benlk benlk added Awaiting Review PR awaiting review and removed Type: Question Further information is requested labels Jul 2, 2020
@benlk
Copy link
Collaborator

benlk commented Jul 2, 2020

This is ready for them to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants