Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing of some unique field in FacultyMember #108

Open
pradumangoyal opened this issue Jun 1, 2020 · 3 comments
Open

Missing of some unique field in FacultyMember #108

pradumangoyal opened this issue Jun 1, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@pradumangoyal
Copy link
Member

Describe the bug
There isn't any unique field in the FacultyMember model currently. There should be a unique field throughout the model which can be used to identify one Faculty from the list. I think employee_id can be one such field, as added in the commit in shell for IIT-R.

@pradumangoyal pradumangoyal added the good first issue Good for newcomers label Jun 1, 2020
@dhruvkb
Copy link
Member

dhruvkb commented Jun 1, 2020

If there are no primary keys, Django adds an id automatically. Is that not adequate?

@pradumangoyal
Copy link
Member Author

pradumangoyal commented Jun 1, 2020

I know about the id, but my concern is identifying the faculty not the primary key. Just like a Student have a unique enrolment number, Faculty should have a unique number.
This can help in two ways:

  1. Whenever there is required a migration from some institute data to the Omniport or vice-versa, there should be some key which maps both the data.
  2. With this we can offer a login through employee_id just like student can login through their enrolment number.

I am not sure if for every institute, faculty get an employee id, but if it is true, there is no field in the Omniport to store this data.

@dhruvkb
Copy link
Member

dhruvkb commented Jun 1, 2020

That's why we added that in shell. We aren't sure if other institutes have this field, so we can't add that field in the kernel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants