Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R algorithms should not require formula as input #14

Open
2 tasks
bartvanb opened this issue Oct 31, 2023 · 0 comments
Open
2 tasks

R algorithms should not require formula as input #14

bartvanb opened this issue Oct 31, 2023 · 0 comments

Comments

@bartvanb
Copy link
Member

Several of the R algorithms currently require a formula as input argument. This needlessly complicates creating tasks for the user, for whom it would be better to provide a list of column names and that the formula is then constructed within the algorithm.

Example:
For the crosstab algorithm I could now provide a function like f="~ site + hospital_id + deadOS" to compute a crosstab grouped by those three columns. I would like instead to provide groupby_cols=['site', 'hospital_id', 'deadOS'] and that the R function is then responsible for creating the function.

Note that the impact of this could be even bigger in the UI, where we will provide column names as a dropdown - the user then only has to select names from a dropdown instead of defining a free text function with column names that they do not know.

Further details:

  • This should be done when moving the R algorithms to v4
  • Check each algorithm if it uses this
  • Fix each algorithm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant