Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Browser compatibility ... ES6 ... FileReader ...! #7

Open
nfreear opened this issue Jun 22, 2018 · 4 comments
Open

Browser compatibility ... ES6 ... FileReader ...! #7

nfreear opened this issue Jun 22, 2018 · 4 comments
Labels
future idea Medium to long term suggestions ...

Comments

@nfreear
Copy link
Contributor

nfreear commented Jun 22, 2018

Hi @timcoughlan,

A few thoughts ... You're obviously pushing the boundaries with things like FileReader etc. — which is great!

I just wondered how we should let the user know ... perhaps have a link at the top of the page to https://browsehappy.com, which is shown/ hidden based on feature-detection?

Also, I noticed a bit of ES6/ES2015 (or 7 or 8 ... I loose track!):

document.addEventListener('keydown', (event) => {
  const keyName = event.key;
  ...
});

(https://github.com/IET-OU/our-journey/blob/master/src/our-journeys.js#L79)

If you want to go that route, its currently best practice (?) to compile from ES6 to ES5 for the browser. We can use a tool like Babel (https://babeljs.io/). (I've not done much ES6, but colleagues used it a fair bit for the new nQuire, with compilation).

Of course, if you're developing for Node, it's less of a problem.

Actually, it may not be necessary to Transpile/compile ?!

I hope that helps.

Ta,

Nick

@timcoughlan
Copy link
Contributor

Hi Nick,
Best to talk this through at some point soon. I've just been developing it for Chrome and aware that it may not work elsewhere but it was important to have a save function up and running as quickly as possible!
The approach to keyboard navigation may be improved upon as well. Still figuring out the best way to support the shift between the svg area and the form.

@nfreear
Copy link
Contributor Author

nfreear commented Jun 22, 2018

Hi,
Yes, the save function should be v. useful!

Just something to consider post-workshop ...

N.

@nfreear nfreear added the future idea Medium to long term suggestions ... label Jun 27, 2018
@nfreear
Copy link
Contributor Author

nfreear commented Jul 9, 2018

I suggest we put something developer-oriented in the README, e.g. based on,

(Start off just saying, e.g. Chrome + Firefox ?)

And, something very simple in the HTML — https://browsehappy.com/, etc.

N.

nfreear added a commit to nfreear/our-journey that referenced this issue Oct 1, 2018
nfreear added a commit to nfreear/our-journey that referenced this issue Oct 1, 2018
* Executed on JS include, not in `require().app.run()`
@nfreear
Copy link
Contributor Author

nfreear commented Oct 12, 2018

Compatibility requirements

Via :~ https://caniuse.com/#index

Do NOT use


{
  "browserslist": [
    "last 1 version",
    "> 1%",
    "not ie < 12"
  ]
}

Browser support / testing

  1. Most testing/ support :- latest Chrome;
  2. Should work / minimal testing :- latest Firefox, Edge(?), Safari, Opera;
  3. May work / no testing :- Baidu, QQ, UC, Opera Mini, Android browser ... (https://browserl.ist/?q=last+1+version)
  4. No compatibility :- all Internet Explorer versions (displays a 'no compatibility' message!)

nfreear added a commit to nfreear/our-journey that referenced this issue Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
future idea Medium to long term suggestions ...
Projects
None yet
Development

No branches or pull requests

2 participants