This repository has been archived by the owner on Nov 25, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Browser compatibility ... ES6 ... FileReader ...! #7
Labels
future idea
Medium to long term suggestions ...
Comments
Hi Nick, |
Hi, Just something to consider post-workshop ... N. |
I suggest we put something developer-oriented in the (Start off just saying, e.g. Chrome + Firefox ?) And, something very simple in the HTML — https://browsehappy.com/, etc. N. |
nfreear
added a commit
to nfreear/our-journey
that referenced
this issue
Oct 1, 2018
nfreear
added a commit
to nfreear/our-journey
that referenced
this issue
Oct 1, 2018
nfreear
added a commit
to nfreear/our-journey
that referenced
this issue
Oct 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi @timcoughlan,
A few thoughts ... You're obviously pushing the boundaries with things like
FileReader
etc. — which is great!I just wondered how we should let the user know ... perhaps have a link at the top of the page to https://browsehappy.com, which is shown/ hidden based on feature-detection?
Also, I noticed a bit of ES6/ES2015 (or 7 or 8 ... I loose track!):
(https://github.com/IET-OU/our-journey/blob/master/src/our-journeys.js#L79)
If you want to go that route, its currently best practice (?) to compile from ES6 to ES5 for the browser. We can use a tool like Babel (https://babeljs.io/). (I've not done much ES6, but colleagues used it a fair bit for the new nQuire, with compilation).
Of course, if you're developing for Node, it's less of a problem.
Actually, it may not be necessary to Transpile/compile ?!
I hope that helps.
Ta,
Nick
The text was updated successfully, but these errors were encountered: