Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Make the CSS styles "portable" #50

Open
nfreear opened this issue Oct 10, 2018 · 0 comments
Open

Make the CSS styles "portable" #50

nfreear opened this issue Oct 10, 2018 · 0 comments
Labels
enhancement New feature or request future idea Medium to long term suggestions ...

Comments

@nfreear
Copy link
Contributor

nfreear commented Oct 10, 2018

Hi @timcoughlan,

There is a short-term & a long-term element to this, to allow the tool to be hosted by third-parties on a page, without it affecting other parts of the page (think possible integration within a VLE).

Long-term

All CSS selectors should start with the container class-name, for example:

.our-journey-js a:link {
    color: #2b6ab7;
}

.our-journey-js form {
    display: inline;
}

/* ... */

The above is best achieved with a CSS pre-processor like SASS or LESS. This may be an extra burden for you, which is why I'm proposing it for the long-term only (!)

Short-term

Ensure that "body" styles (font-family, font-size etc.) are set on the container, not on the <body>.

All will hopefully become clear ;).

Ta,

Nick

@nfreear nfreear added future idea Medium to long term suggestions ... enhancement New feature or request labels Oct 10, 2018
nfreear added a commit to nfreear/our-journey that referenced this issue Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request future idea Medium to long term suggestions ...
Projects
None yet
Development

No branches or pull requests

1 participant