Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Switch to stacked chart #464

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

markbotterill
Copy link
Contributor

Reviewer: @sidravi1 @lickem22
Estimate: 1 hour


Ticket

Fixes: JIRA_TICKET_LINK

Description

Fixes existing line chart bug where queries weren't showing up correctly + replaced the line chart with a swishy bar chart instead.

Goal

Address UI feedback on the dashboard + fix minor bug.

Changes

  1. Fix the bug in the backend: Only queries that had feedback assigned were being considered in the pre-existing line chart. Changed the filtering logic to that all queries were considered appropriately.
  2. Changed schema in the backend to accommodate the overlap of "urgent" and "downvoted"
  3. Created queries to capture data for all 4 categories
  4. Created a new parsing function on the frontend to read the TS data in appropriately
  5. Replaced the existing LineChart with a StackedChart instead

Future Tasks (optional)

How has this been tested?

All tests still pass + front-end works seamlessly. However, I think a full overhaul of the test_dashboard_overview.py is still needed.

To-do before merge (optional)

Fix tests

Checklist

Fill with x for completed.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts

(Delete any items below that are not relevant)

  • I have updated the automated tests
  • I have updated the scripts in scripts/
  • I have updated the requirements
  • I have updated the README file
  • I have updated affected documentation
  • I have added a blogpost in Latest Updates
  • I have updated the CI/CD scripts in .github/workflows/
  • I have updated the Terraform code

Copy link
Contributor

@lickem22 lickem22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @markbotterill , Looks good overall I added a couple of comments regarding the code.
Regarding the dashboard a couple of things:

  1. The 4th Barchart always have a different shade of green.
Screenshot 2024-12-04 at 17 09 47
  1. For the Year barchart, could you get a monthly barchart instead of biweekly?
Screenshot 2024-12-04 at 17 11 04 3) For the weekly barchart, I think it would be nice to add day of week as well. To make it readable. Please let me know when you make the changes and add the tests so I can approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants