-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Switch to stacked chart #464
Open
markbotterill
wants to merge
12
commits into
main
Choose a base branch
from
feature/switch-to-stacked-chart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbotterill
requested review from
sidravi1,
suzinyou,
lickem22,
amiraliemami,
Tanmay-97 and
tonyzhao6
as code owners
December 3, 2024 14:25
lickem22
reviewed
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @markbotterill , Looks good overall I added a couple of comments regarding the code.
Regarding the dashboard a couple of things:
- The 4th Barchart always have a different shade of green.
- For the Year barchart, could you get a monthly barchart instead of biweekly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @sidravi1 @lickem22
Estimate: 1 hour
Ticket
Fixes: JIRA_TICKET_LINK
Description
Fixes existing line chart bug where queries weren't showing up correctly + replaced the line chart with a swishy bar chart instead.
Goal
Address UI feedback on the dashboard + fix minor bug.
Changes
Future Tasks (optional)
How has this been tested?
All tests still pass + front-end works seamlessly. However, I think a full overhaul of the
test_dashboard_overview.py
is still needed.To-do before merge (optional)
Fix tests
Checklist
Fill with
x
for completed.(Delete any items below that are not relevant)
scripts/
.github/workflows/