Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create function to allow a new definitions file to be added #49

Closed
ChrisMarsh82 opened this issue Jan 10, 2024 · 2 comments
Closed

Create function to allow a new definitions file to be added #49

ChrisMarsh82 opened this issue Jan 10, 2024 · 2 comments

Comments

@ChrisMarsh82
Copy link

Function so that a new definitions file can be added for a station.

inputs: country, station_id, definitions

This should not delete the existing definitions file but date stamp the files added.

Only the latest definitions file should be accessed by the functions. The historical definitions will not need to be accessed at the moment as this work is out of scope of this issue.

@lilyclements
Copy link
Collaborator

lilyclements commented Jan 16, 2024

@ChrisMarsh82 This function belongs in epicsadata since it relates to the data. I have made this function under add_definitions_to_bucket.
I have also amended the function to get the data from the bucket (get_definitions_data). This now will get the most recent definitions data if there is multiple, or otherwise will just get one.

The PR for this in the epicsadata package is given here IDEMSInternational/epicsadata#11

I've then written a wrapper function for epicsawrap so that this can be accessed from this package - this is in PR #57. If you're happy with this, then this issue can be closed as completed

@lilyclements lilyclements moved this to In review in e-PICSA Jan 16, 2024
@ChrisMarsh82
Copy link
Author

see #90

@github-project-automation github-project-automation bot moved this from In review to Done in e-PICSA Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants