Tidy Query

ICanBoogie · Nov 2, 2024 · 4bd98fa · 4bd98fa
1 parent 80bf3c6
commit 4bd98fa
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 12 deletions.
diff --git a/lib/ActiveRecord.php b/lib/ActiveRecord.php
@@ -225,6 +225,7 @@ public function save(bool $skip_validation = false): void
             assert(is_numeric($id));
         }
 
+        // @phpstan-ignore-next-line
         $rc = $model->save($properties, $id);
 
         if ($id === null) {

diff --git a/lib/ActiveRecord/Driver/TableRenderer.php b/lib/ActiveRecord/Driver/TableRenderer.php
@@ -20,11 +20,6 @@
 
 abstract class TableRenderer
 {
-    /**
-     * @param non-empty-string $prefixed_table_name
-     *
-     * @return non-empty-string
-     */
     public function render(Schema $schema, string $prefixed_table_name): string
     {
         $column_defs = implode(",\n", $this->render_column_defs($schema));
@@ -54,9 +49,6 @@ abstract protected function render_table_constraints(Schema $schema): array;
 
     /**
      * @param Schema $schema
-     * @param non-empty-string $prefixed_table_name
-     *
-     * @return non-empty-string
      */
     abstract protected function render_create_index(Schema $schema, string $prefixed_table_name): string;
 

diff --git a/lib/ActiveRecord/Table.php b/lib/ActiveRecord/Table.php
@@ -94,8 +94,6 @@ private function make_select_join(): string
 
     public Schema $extended_schema;
 
-    public Schema $extended_schema;
-
     /**
      * Returns the extended schema.
      */
@@ -486,8 +484,6 @@ public function update(array $values, int|string $key): void
         $values[] = $key;
 
         $this->execute($query, $values);
-
-        return true;
     }
 
     /**