-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature proposal: automated workflow for temperature induced solid-solid transition #143
Comments
Sounds like a great idea to me. An initial version without checks also sound fine to me. I would ba happy to support the implementation as needed. Thanks! |
Ok. I would start on friday. Are you available during the day, if I have already a working prototype? |
Yes, I will be available. |
Three questions:
|
this would be mostly in 'input.py'. I could also take over this part if you wish. We can merge it into a branch and finish up.
|
Have a look at the current changes I did on my fork: https://github.com/stefanhiemer/calphy So far the changes are untested and mostly based on copying the melting temperature routine: -kicked out the melting check in routines.py As soon as I understand how to add the signature string, I will start testing/debugging. As string I would suggest transformation_temperature. |
Hi Sarath, I just started testing my implementation and encountered an unrelated bug (or a hole in my understanding of calphy). I try this temperature scaling script. Traceback (most recent call last): Thanks and regards PS: Have you checked out my fork? |
@stefanhiemer Just about the issue above; this is not supported anymore. You can only have one value in lattice, and have to add a separate calculation for each, like this:
|
A bit incovenient, but the reason was to simply the input for the code, and to make it be able to choose the parameters for each calculation differently. Now, you can only have one simulation in each block. |
Todo:
|
Hi there,
I would like to create a workflow similar as the melting protocol, but it is even easier here as we do not have to check for melting or solidification. The workflow is identical to here, but without the melting checks:
https://calphy.org/en/latest/examples/example_04/analysis.html
If someone fears that his phases transform during transformation, one would have to implement checks, but that may be difficult to set up in a framework that works for arbitrary unit cells / solid phases. Further generalizations of this may be to extend this to composition and pressure variation as in example.
If you agree, I would start editing routines.py and copy the class MeltingTemp. My test case would be a comparison with the manual calculation of the transition temperature in Example 02.
Regards
Stefan
The text was updated successfully, but these errors were encountered: