Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Accessibility checker no longer ignores hidden blocks (regression) #2109

Open
wkeese opened this issue Nov 25, 2024 · 0 comments
Open

[BUG]: Accessibility checker no longer ignores hidden blocks (regression) #2109

wkeese opened this issue Nov 25, 2024 · 0 comments
Labels
Bug Something isn't working extension-checker Issues related to the browser extensions T64 user-reported Issues identified outside of the core team

Comments

@wkeese
Copy link

wkeese commented Nov 25, 2024 •
edited
Loading

Project

accessibility-checker-engine

Browser

Chrome

Operating system

MacOS

Description

EAAC should ignore blocks that are display: none, visibility: hidden, and/or aria-hidden="true. It used to work that way, up to the Oct 1, 2024 deployment. But after that (starting with the Nov 6, 2024 ruleset), it scans those blocks.

This leads to spurious error messages such as:

Multiple elements with "region" landmarks within the same parent region are not distinguished from one another because they have the same "data table toolbar" label

Steps to reproduce

Unlike #2103 this happens in both Node and on Chrome. A minimal test case is:

<html lang="en">
<head>
    <title>Test that display:none blocks are ignored</title>
</head>
<body>
    <main>
        <section aria-label="my section">
            This section is visible.
        </section>
        <section aria-label="my section" style="display: none">
            This section has the same label but is display:none, so there shouldn't be an error.
        </section>
    </main>
</body>
</html>

The problem also happens though with visibility: hidden and aria-hidden="true".
@wkeese wkeese changed the title [BUG]: Accessibility checker no longer ignores display:none blocks [BUG]: Accessibility checker no longer ignores hidden blocks Nov 25, 2024
@wkeese wkeese changed the title [BUG]: Accessibility checker no longer ignores hidden blocks [BUG]: Accessibility checker no longer ignores hidden blocks (regression) Nov 26, 2024
@MHoov MHoov added Bug Something isn't working extension-checker Issues related to the browser extensions user-reported Issues identified outside of the core team labels Dec 3, 2024
@shunguoy shunguoy added the T64 label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working extension-checker Issues related to the browser extensions T64 user-reported Issues identified outside of the core team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wkeese @shunguoy @MHoov