fixrule(img_alt_valid) Reports "inapplicable" while ACT 23a2a8 expects "Failed" for Fail Example 2

[philljenkins]

Checker rule img_alt_valid reports inconsistent with ACT rule(s) below (updated with 7 November results):

• Failed examples should be failed by at least one of the Checker rules fail reason codes.
• Checker should be mapping (report against) the same success criteria as what is expected by the ACT rule.

2. Partially consistent with ACT rule: Image has non-empty accessible name 23a2a8:
   • Mapping: The Checker implementation correctly reports which success criteria ACT expects are failed by this rule: 1.1.1.
   • "inapplicable" Failed Example 2 is incorrectly reported by Checker rule img_alt_valid as "inapplicable", should be "failed".
   • opened this issue to resolve

Reference

• Checker's Implementation report of ACT rules https://www.w3.org/WAI/standards-guidelines/act/implementations/equal-access/ (updated 7 November 2024)
• Checker's raw results sent to ACT https://unpkg.com/[email protected]/act-report-v2.txt
• Checker's Rule mapping spreadsheet file on box

[philljenkins]

Failed Example 2 Open in a new tab

This element with role of img has an empty accessible name.

<div role="img" style="width:72px; height:48px; background-image: url(/test-assets/shared/w3c-logo.png)"></div>

Checker flags this div using a different rule, reason code, level, and mapping that doesn't report against this ACT rule rule: 23a2a8 :

• Rule ID: aria_accessiblename_exists
• Reason ID: fail_no_accessible_name
• Recommendation, ACT will expect Violation [can we report Fail to ACT with Recommendation?]
• Maps to 4.1.2, ACT will expect 1.1.1
• Element <div> with "img" role has no accessible name Learn more
• "Elements with certain roles should have accessible names"

[philljenkins]

After discussion with Tom, an option is to add a new fail reason code to

• Rule ID: aria_accessiblename_exists
• new reason for something such as: "fail_no_accessible_name_img_role"
• reasonCodes: ["fail_no_accessible_name_img_role"]
• and map the new reason code to 1.1.1 (not 4.1.2 as rest of the rule)

See target_spacing_sufficient.ts as an example of separating the reasonCodes:

[philljenkins]

@shunguoy
The Checker is still incorrectly reporting as Inapplicable when Checker should report as Failed.

See mapping results from the PR #2108 's Artifact ACT Text Results:

* Image has non-empty accessible name (https://www.w3.org/WAI/standards-guidelines/act/rules/23a2a8)
  + Passed Example 1: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/32bfac8a98cc212aa7bf9151bf40f665a7f51696.html
  + Passed Example 2: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/38cc6a87fcc81fcc2248f0cd74ca48396b7aa432.html
  + Passed Example 3: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/feb06eece7b158ab66a25bfa2c47a196309f0d93.html
  + Passed Example 4: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/40d83620b0bcbcf0e7380177384f48596823e7a9.html
  + Passed Example 5: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/2f35ed62ed14afb6d9e8b886e95e846f0cfa0d2a.html
  + Passed Example 6: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/e8f40f5af06646ef15283302903f6c78f7d7a505.html
  + Passed Example 7: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/13b8678881fba03e7465f82b5550abc5093f7968.html
  + Passed Example 8: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/ba9cdf6d0c336f0abf7cd2992c4a2a62c6c719fd.html
  + Failed Example 1: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/8006d1541dc71b93e6ec4d101a386e0043d1a521.html
  + Failed Example 2: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/496963cfd35d4873c010469c47c84d4358fba035.html
    �[31m--Expected failed, but returned earl:inapplicable
    Failures: []
    Review: []
    Pass: []
    All: [
      "html_skipnav_exists:Potential_1:POTENTIAL",
      "skip_main_exists:Fail_1:FAIL",
      "style_color_misuse:Potential_1:POTENTIAL",
      "style_highcontrast_visible:Manual_1:MANUAL"
    ]�[0m

I think the problem is that the "new Reason code" created does not map to the ACT ruleID 23a2a8, so it';s not reported to ACT.
See your code in new Checker rule file for
accessibility-checker-engine/src/v4/rules/aria_accessiblename_exists.ts, it's missing the ACT ruleID:

...
{
        "id": ["IBM_Accessibility", "IBM_Accessibility_next", "WCAG_2_1", "WCAG_2_0", "WCAG_2_2"],
        "num": ["ARIA"],
        "level": eRulePolicy.RECOMMENDATION,
        "toolkitLevel": eToolkitLevel.LEVEL_ONE,
        reasonCodes: ["fail_no_accessible_name_image"]
    }],
    act: [],
    run: (context: RuleContext, options?: {}, contextHierarchies?: RuleContextHierarchy): RuleResult | RuleResult[] => {
        const ruleContext ...

[philljenkins]

@tombrunet is investigating why the ReasonCode(s) is not being picked up correctly

• fail_no_accessible_name
• fail_no_accessible_name_image

Checker RuleID aria_accessiblename_exists.ts seems to correctly have the ACT mapping specified:
act: [{"23a2a8": {"fail_no_accessible_name_image": "fail"}}],

[shunguoy]

[philljenkins]

Following latest commit regarding the bug in the rule mapping, the Checker now correctly reports failures for the ACT testcases:

See mapping results below from the PR #2108 's Artifact ACT Text Results:

* Image has non-empty accessible name (https://www.w3.org/WAI/standards-guidelines/act/rules/23a2a8)
  + Passed Example 1: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/32bfac8a98cc212aa7bf9151bf40f665a7f51696.html
  + Passed Example 2: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/38cc6a87fcc81fcc2248f0cd74ca48396b7aa432.html
  + Passed Example 3: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/feb06eece7b158ab66a25bfa2c47a196309f0d93.html
  + Passed Example 4: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/40d83620b0bcbcf0e7380177384f48596823e7a9.html
  + Passed Example 5: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/2f35ed62ed14afb6d9e8b886e95e846f0cfa0d2a.html
  + Passed Example 6: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/e8f40f5af06646ef15283302903f6c78f7d7a505.html
  + Passed Example 7: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/13b8678881fba03e7465f82b5550abc5093f7968.html
  + Passed Example 8: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/ba9cdf6d0c336f0abf7cd2992c4a2a62c6c719fd.html
  + Failed Example 1: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/8006d1541dc71b93e6ec4d101a386e0043d1a521.html
  + Failed Example 2: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/496963cfd35d4873c010469c47c84d4358fba035.html
  + Failed Example 3: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/fef9a3ad8b2f2a6beeaf44ef7dafce08e743ea67.html
  + Failed Example 4: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/b0348c1e6fced2df1ebd93caef4d383f6c7a0461.html
  + Failed Example 5: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/d70470a37db713810be85275e5d0c698f85ab320.html
  + Inapplicable Example 1: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/cd3b3a4046451da9b9cc3e166c09d27583a2c30b.html
  + Inapplicable Example 2: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/25e5364c0a1320a08e2742fa59a0f8627591bc61.html
  + Inapplicable Example 3: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/e15b9aca4aaa53cb3a96ae48e78e1af064b9a01d.html
  + Inapplicable Example 4: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/7d696551efaafa0da33bb6e56b8b43707c7c7de9.html
  + Inapplicable Example 5: https://www.w3.org/WAI/content-assets/wcag-act-rules/testcases/23a2a8/f7692caf5f8c788d58e1aeb8d4f1f240fafdfa91.html