Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all defined interfaces for v2.0.x #100

Closed
zFernand0 opened this issue Mar 6, 2024 · 1 comment · Fixed by #101
Closed

Export all defined interfaces for v2.0.x #100

zFernand0 opened this issue Mar 6, 2024 · 1 comment · Fixed by #101
Assignees

Comments

@zFernand0
Copy link

Right now we only export the ./lib/ZosAccessor.d.ts . However, I believe it will be beneficial if we exported everything inside interfaces in order to avoid extenders/developers importing from a package subdirectory

See the example below

import { SpoolFile } from "zos-node-accessor/lib/interfaces/SpoolFile";
import { Job, JobStatus } from "zos-node-accessor/lib/interfaces/Job";
import { JobListOption } from "zos-node-accessor/lib/interfaces/JobListOption";
import { JobLogOption } from "zos-node-accessor/lib/interfaces/JobIdOption";

More examples can be found in this PR:

@std4lqi std4lqi self-assigned this Mar 9, 2024
@std4lqi
Copy link
Member

std4lqi commented Mar 12, 2024

Hi @zFernand0 , I create PR #101 . Let me know please, if any comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants