Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cloud Databases): Key protect revert fix #5870

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

lornakelly
Copy link
Contributor

@lornakelly lornakelly commented Dec 12, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Revert part this PR #5798 to address this bug #5863
Keep acceptance test edits as those are still applicable

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstance_Redis_Basic'
== RUN   TestAccIBMDatabaseInstance_Redis_Basic
=== PAUSE TestAccIBMDatabaseInstance_Redis_Basic
=== CONT  TestAccIBMDatabaseInstance_Redis_Basic
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (860.29s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        864.981s

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstanceRedisImport'
=== RUN   TestAccIBMDatabaseInstanceRedisImport
=== PAUSE TestAccIBMDatabaseInstanceRedisImport
=== CONT  TestAccIBMDatabaseInstanceRedisImport
--- PASS: TestAccIBMDatabaseInstanceRedisImport (431.23s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        438.401s

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstanceRabbitmqImport'
=== RUN   TestAccIBMDatabaseInstanceRabbitmqImport
=== PAUSE TestAccIBMDatabaseInstanceRabbitmqImport
=== CONT  TestAccIBMDatabaseInstanceRabbitmqImport
--- PASS: TestAccIBMDatabaseInstanceRabbitmqImport (492.87s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        498.222s

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstancePostgresImport'
=== RUN   TestAccIBMDatabaseInstancePostgresImport
=== PAUSE TestAccIBMDatabaseInstancePostgresImport
=== CONT  TestAccIBMDatabaseInstancePostgresImport
--- PASS: TestAccIBMDatabaseInstancePostgresImport (561.86s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        582.950s

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstanceEtcdImport'
=== RUN   TestAccIBMDatabaseInstanceEtcdImport
=== PAUSE TestAccIBMDatabaseInstanceEtcdImport
=== CONT  TestAccIBMDatabaseInstanceEtcdImport
--- PASS: TestAccIBMDatabaseInstanceEtcdImport (649.21s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        655.110s

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstanceElasticsearchImport'
=== RUN   TestAccIBMDatabaseInstanceElasticsearchImport
=== PAUSE TestAccIBMDatabaseInstanceElasticsearchImport
=== CONT  TestAccIBMDatabaseInstanceElasticsearchImport
--- PASS: TestAccIBMDatabaseInstanceElasticsearchImport (499.18s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        (cached)
...

@lornakelly lornakelly changed the title Lk/1600/key protect revert Key protect revert fix Dec 12, 2024
Copy link
Collaborator

@omaraibrahim omaraibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lornakelly lornakelly changed the title Key protect revert fix fix(Cloud Databases): Key protect revert fix Dec 13, 2024
@omaraibrahim omaraibrahim merged commit 0e3048b into IBM-Cloud:master Dec 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants