Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datasource] Add host reference to power dedicated host data sources #5834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Datasource] Add host reference to power dedicated host data sources #5834

wants to merge 1 commit into from

Conversation

Alexander-Kita
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

pi_host (d)

=== RUN   TestAccIBMPIHostDataSourceBasic
--- PASS: TestAccIBMPIHostDataSourceBasic (82.79s)
PASS

pi_hosts (d)

=== RUN   TestAccIBMPIHostsDataSourceBasic
--- PASS: TestAccIBMPIHostsDataSourceBasic (80.24s)
PASS

@Alexander-Kita Alexander-Kita mentioned this pull request Dec 3, 2024
Closed
@Alexander-Kita Alexander-Kita added the service/Power Systems Issues related to Power Systems label Dec 3, 2024
yussufsh
yussufsh requested changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the doc as well with this new attribute?

@Alexander-Kita
Copy link
Collaborator Author

@yussufsh Added and fixed some spacing in dedicated host docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia ismirlia approved these changes

@hkantare hkantare Awaiting requested review from hkantare

@michaelkad michaelkad Awaiting requested review from michaelkad

@yussufsh yussufsh Awaiting requested review from yussufsh

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexander-Kita @yussufsh @ismirlia