Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Cloud Databases): Update Database Password Complexity Validation #5701

Merged

Conversation

alexhemard
Copy link
Collaborator

@alexhemard alexhemard commented Oct 4, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Please note, effective 15 December 2024, IBM Cloud Databases is changing how we enforce password complexity for database users created using the UI and API.

What are we changing?

IBM Cloud Databases will begin enforcing password complexity validation for database users created using the IBM Cloud console, CLI, API and Terraform. Database user passwords will be required to be a minimum of 15 characters, contain at least one letter and number and a mix of uppercase and lowercase letters.

This adds client side validation for the new database password complexity requirements that will go in effect December 15, 2024.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstance'

--- PASS: TestAccIBMDatabaseInstanceMongodbImport (370.45s)
--- PASS: TestAccIBMDatabaseInstanceEtcdImport (481.88s)
--- PASS: TestAccIBMDatabaseInstanceRabbitmqImport (562.93s)
--- PASS: TestAccIBMDatabaseInstanceRedisImport (570.76s)
--- PASS: TestAccIBMDatabaseInstancePostgresImport (672.71s)
--- PASS: TestAccIBMDatabaseInstanceElasticsearchImport (463.82s)
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (858.17s)
--- PASS: TestAccIBMDatabaseInstance_Rabbitmq_Basic (874.56s)
--- PASS: TestAccIBMDatabaseInstanceMySQLReadReplicaPromotion (1269.13s)
--- PASS: TestAccIBMDatabaseInstancePostgresPITR (1394.44s)
--- PASS: TestAccIBMDatabaseInstance_Elasticsearch_Basic (890.80s)
--- PASS: TestAccIBMDatabaseInstanceMongodbBasic (1552.88s)
--- PASS: TestAccIBMDatabaseInstancePostgresReadReplicaPromotion (1602.17s)
--- PASS: TestAccIBMDatabaseInstance_ElasticsearchPlatinum_Basic (1585.24s)
--- PASS: TestAccIBMDatabaseInstance_ElasticsearchPlatinum_Group (2428.03s)
--- PASS: TestAccIBMDatabaseInstance_ElasticsearchPlatinum_Node (3007.49s)
--- PASS: TestAccIBMDatabaseInstance_Etcd_Basic (3906.19s)
--- PASS: TestAccIBMDatabaseInstanceEDBReadReplicaPromotion (4128.39s)

go test github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	0.797s


...

@alexhemard alexhemard marked this pull request as ready for review December 12, 2024 19:54
omaraibrahim
omaraibrahim previously approved these changes Dec 12, 2024
Copy link
Collaborator

@omaraibrahim omaraibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@omaraibrahim omaraibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexhemard alexhemard merged commit 03009cb into IBM-Cloud:master Dec 13, 2024
1 check passed
@alexhemard alexhemard deleted the 2024-database-password-complexity branch December 13, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants