Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commas in results data? #640

Open
stevieflow opened this issue Mar 3, 2022 · 5 comments
Open

Commas in results data? #640

stevieflow opened this issue Mar 3, 2022 · 5 comments

Comments

@stevieflow
Copy link

Hello

We were previewing some bigger target and actual numbers in IATI results:

d-preview (12)

They are difficult to parse, by sight - could it be possible to include the relevant commas in the numbers (as you do for budgets and transaction values)?

Thanks!

@notshi
Copy link
Collaborator

notshi commented Mar 3, 2022

Sure, do you have links to some examples?

There may be some problems with results if numbers are not expected; ie. the standard allows @value to be many things that are not numbers.

@stevieflow
Copy link
Author

Thanks @notshi

Actually - ignore me!

I noticed that the schema declares this value field as a string: https://iatistandard.org/en/iati-standard/203/activity-standard/iati-activities/iati-activity/result/indicator/period/target/

And - on checking:

https://datasette.codeforiati.org/iati/result_indicator_period_actual?value__notblank=1&_sort_desc=value

There's a lot of strings in this field!

I can therefore format the data with commas. Case closed. Thanks for your advice

@notshi
Copy link
Collaborator

notshi commented Mar 5, 2022

I can therefore format the data with commas.

Publishing with commas could make it hard to discern that we are dealing with numbers (as a data consumer).
This will also affect the completion percentages you find in the result section of SAVi.
Also in different locales, commas can mean decimal points which can make the numbers even more confusing.

@stevieflow
Copy link
Author

Ah ha! Thanks @notshi - Ill revert back to "numbers" therefore

To the original query - given the widespread mix of strings and numbers, is there anything you can do at the d-portal end to format the numbers?

@notshi
Copy link
Collaborator

notshi commented Mar 7, 2022

Yup, we will take a look and see how best we can do this. Should we re-open this issue?

@stevieflow stevieflow reopened this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants