Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] NPM install global does not install the package-lock.json #28

Open
BrettCleary opened this issue May 3, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@BrettCleary
Copy link
Contributor

When running npm install -g @hyperplay/cli, the package-lock.json file is not installed. This means only the semver in the package.json is used to resolve dependencies.

This was a source of bugs when running locally and in CI with 2.9.5 valist/sdk in the package-lock.json was being used, but when installed globally, the ^2.9.5 valist/sdk version from the package.json was being used. Thus 2.9.6 was being installed and breaking the publish command even though all the tests were passing.

We should figure out a way to ship the package-lock.json (files array in package.json did not work) or ignore the package-lock.json in the CI for running the tests. This way we can test with the same dependency packages that are being used in production and prevent this class of bugs.

@BrettCleary BrettCleary added the bug Something isn't working label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant