Skip to content
This repository has been archived by the owner on Jul 22, 2019. It is now read-only.

Ability to ignore files for parsing #77

Closed
2 tasks done
nevadascout opened this issue Jun 17, 2016 · 14 comments
Closed
2 tasks done

Ability to ignore files for parsing #77

nevadascout opened this issue Jun 17, 2016 · 14 comments
Assignees
Milestone

Comments

@nevadascout
Copy link
Member

nevadascout commented Jun 17, 2016

Being able to ignore a set of files from parsing would bypass the smarty issues (#76) and would generally be a nice feature.

  • Ignore an array of files
  • Ignore an array of folders
@nevadascout nevadascout added this to the 0.1.8 milestone Jun 17, 2016
@nevadascout nevadascout self-assigned this Jun 17, 2016
@TheColorRed
Copy link
Contributor

I think this would be a great use of #64 (adding a phpconfig.json).

@michalhudecek
Copy link

Yes, this would be perfect. It would be a workaround for plenty of bugs with stuck indexing.

@michalhudecek
Copy link

@nevadascout Wouldn't this be much faster than waiting on update of php-parser?

@nevadascout nevadascout added this to the 0.3.0 milestone Oct 22, 2016
@nevadascout
Copy link
Member Author

@michalhudecek Yes, it would... Adding this to next release!

@michalhudecek
Copy link

@nevadascout Any ETA for the next release?

@nevadascout
Copy link
Member Author

Not sure, a few weeks maybe.

Could create a minor release with this feature in the short term though...

@michalhudecek
Copy link

That would be great

@nevadascout
Copy link
Member Author

Added in the v0.2.2 release

@michalhudecek
Copy link

@nevadascout Great. Thanks a lot. I tried to use it and set up this in settings:

    "crane.ignoredPaths": [
        "/vendor/evernote/*"
    ]

But it still gets stuck while indexing Evernote. What am I doing wrong?

image

@michalhudecek
Copy link

@nevadascout Is there any documentation for the settings for this feature? Am I doing something wrong?

@TheColorRed
Copy link
Contributor

TheColorRed commented Nov 2, 2016

@michalhudecek Try this:

 "crane.ignoredPaths": [
        "vendor/evernote"
    ]

Or this:

 "crane.ignoredPaths": [
        "vendor/evernote/**"
    ]

@nevadascout
Copy link
Member Author

@michalhudecek Sorry, I saw this but forgot to reply!

As @TheColorRed's code shows, I think it's because you've got a / at the start of the path

@kiatng
Copy link

kiatng commented Nov 28, 2016

I am a total noob to vscode. Where do I find phpconfig.json to configure crane.ignoredPaths?

[edit]
Read the source code and found this reference:
public static craneSettings = workspace.getConfiguration("crane");
in crane/client/src/utils/Config.ts

For other noob, the configuration is located in vscode > FIle > Preferences > Workspace Settings

@ysmnikhil
Copy link

I tried both @TheColorRed suggestions but still loading cache folders. Any suggestions ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants