Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Proton Scatter node crashes editor in Godot 4.3 #206

Open
lovhb opened this issue Sep 12, 2024 · 20 comments
Open

Adding Proton Scatter node crashes editor in Godot 4.3 #206

lovhb opened this issue Sep 12, 2024 · 20 comments

Comments

@lovhb
Copy link

lovhb commented Sep 12, 2024

Steps to reproduce:

  1. Open Godot 4.3 project
  2. Add Proton Scatter node to scene

This causes the editor to close/crash.

Tried downloading from github and asset store, same result.

@NothingAnimated
Copy link

Having the exact same issue.

@Metriximor
Copy link

Can confirm in 4.4 Dev 3 as well. Interestingly enough, it's only when I open the 3D editor that it crashes, if I just open scripts it works fine.

@mkgiga
Copy link

mkgiga commented Oct 12, 2024

I also experience this issue -- I'm using Terrain3D as well. If I wait a little in the Script tab when loading my project instead of going to the 3D scene, I can get into the 3D scene view, but the moment I try to move the scatter shape node, it causes the "Loading" circle to appear for a split second, then the program crashes. If I linger in the 3D scene view as the project loads, godot crashes too. Is this related to compute shaders calling some sort of unsupported function on older hardware? I've got a GTX 980 Ti and I noticed at some point when starting the editor through verbose mode through powershell I got this message.

Devices:
  #0: NVIDIA NVIDIA GeForce GTX 980 Ti - Unsupported, Discrete
Optional extension VK_KHR_fragment_shading_rate not found
- Vulkan Variable Rate Shading not supported
- Vulkan multiview supported:
  max view count: 32
  max instances: 134217727
- Vulkan subgroup:
  size: 32
  min size: 32
  max size: 32
  stages: STAGE_VERTEX, STAGE_TESSELLATION_CONTROL, STAGE_TESSELLATION_EVALUATION, STAGE_GEOMETRY, STAGE_FRAGMENT, STAGE_COMPUTE
  supported ops: FEATURE_BASIC, FEATURE_VOTE, FEATURE_ARITHMETIC, FEATURE_BALLOT, FEATURE_SHUFFLE, FEATURE_SHUFFLE_RELATIVE, FEATURE_CLUSTERED, FEATURE_QUAD, FEATURE_PARTITIONED_NV
  quad operations in all stages
Devices:
  #0: NVIDIA NVIDIA GeForce GTX 980 Ti - Unsupported, Discrete
Optional extension VK_KHR_fragment_shading_rate not found
- Vulkan Variable Rate Shading not supported
- Vulkan multiview supported:
  max view count: 32
  max instances: 134217727
- Vulkan subgroup:
  size: 32
  min size: 32
  max size: 32
  stages: STAGE_VERTEX, STAGE_TESSELLATION_CONTROL, STAGE_TESSELLATION_EVALUATION, STAGE_GEOMETRY, STAGE_FRAGMENT, STAGE_COMPUTE
  supported ops: FEATURE_BASIC, FEATURE_VOTE, FEATURE_ARITHMETIC, FEATURE_BALLOT, FEATURE_SHUFFLE, FEATURE_SHUFFLE_RELATIVE, FEATURE_CLUSTERED, FEATURE_QUAD, FEATURE_PARTITIONED_NV
  quad operations in all stages
Creating VMA small objects pool for memory type index 7
Devices:
  #0: NVIDIA NVIDIA GeForce GTX 980 Ti - Unsupported, Discrete
Optional extension VK_KHR_fragment_shading_rate not found
- Vulkan Variable Rate Shading not supported
- Vulkan multiview supported:
  max view count: 32
  max instances: 134217727
- Vulkan subgroup:
  size: 32
  min size: 32
  max size: 32
  stages: STAGE_VERTEX, STAGE_TESSELLATION_CONTROL, STAGE_TESSELLATION_EVALUATION, STAGE_GEOMETRY, STAGE_FRAGMENT, STAGE_COMPUTE
  supported ops: FEATURE_BASIC, FEATURE_VOTE, FEATURE_ARITHMETIC, FEATURE_BALLOT, FEATURE_SHUFFLE, FEATURE_SHUFFLE_RELATIVE, FEATURE_CLUSTERED, FEATURE_QUAD, FEATURE_PARTITIONED_NV
  quad operations in all stages
Creating VMA small objects pool for memory type index 7
Devices:
  #0: NVIDIA NVIDIA GeForce GTX 980 Ti - Unsupported, Discrete
Optional extension VK_KHR_fragment_shading_rate not found
- Vulkan Variable Rate Shading not supported
- Vulkan multiview supported:
  max view count: 32
  max instances: 134217727
- Vulkan subgroup:
  size: 32
  min size: 32
  max size: 32
  stages: STAGE_VERTEX, STAGE_TESSELLATION_CONTROL, STAGE_TESSELLATION_EVALUATION, STAGE_GEOMETRY, STAGE_FRAGMENT, STAGE_COMPUTE
  supported ops: FEATURE_BASIC, FEATURE_VOTE, FEATURE_ARITHMETIC, FEATURE_BALLOT, FEATURE_SHUFFLE, FEATURE_SHUFFLE_RELATIVE, FEATURE_CLUSTERED, FEATURE_QUAD, FEATURE_PARTITIONED_NV
  quad operations in all stages
Creating VMA small objects pool for memory type index 7
Devices:
  #0: NVIDIA NVIDIA GeForce GTX 980 Ti - Unsupported, Discrete
Optional extension VK_KHR_fragment_shading_rate not found
- Vulkan Variable Rate Shading not supported
- Vulkan multiview supported:
  max view count: 32
  max instances: 134217727
- Vulkan subgroup:
  size: 32
  min size: 32
  max size: 32
  stages: STAGE_VERTEX, STAGE_TESSELLATION_CONTROL, STAGE_TESSELLATION_EVALUATION, STAGE_GEOMETRY, STAGE_FRAGMENT, STAGE_COMPUTE
  supported ops: FEATURE_BASIC, FEATURE_VOTE, FEATURE_ARITHMETIC, FEATURE_BALLOT, FEATURE_SHUFFLE, FEATURE_SHUFFLE_RELATIVE, FEATURE_CLUSTERED, FEATURE_QUAD, FEATURE_PARTITIONED_NV
  quad operations in all stages

@zachrussell12
Copy link

Also here to confirm this is happening to me in Godot v4.3.stable unfortunately.

@chase102496
Copy link

Another confirming the same thing

@HungryProton
Copy link
Owner

I can't reproduce the issue on my end, can anyone give me more info?

OS, renderer, GPU model.

Also, did it happened on Godot 4.2 or is it a new thing only happening in 4.3 ?

@zachrussell12
Copy link

For me:

OS: Windows 10
Renderer: Forward+
GPU: Nvidia GeForce RTX 3080

I was using Godot 4.3 when I was having the issue. I did not check to see if it happened on 4.2.

@Klaim
Copy link

Klaim commented Oct 30, 2024

Windows 11, Forward+, Nvidia GeForce 3080 Ti, Godot 4.3
Didn't try other versions yet as I'm in the middle of a house move. Ill try to get more info once I'm setup

@Klaim
Copy link

Klaim commented Oct 30, 2024

BTW I tried it in a new project (to test the plugin). Some issues with Godot can stay hidden until the cache directory is deleted first, so maybe that's why you don't reproduce it? 🤔

@lovhb
Copy link
Author

lovhb commented Oct 30, 2024

My specs:
OS: Windows 11
Renderer: Forward+
GPU: Nvidia GeForce RTX 3070
CPU: Intel i7-10700

I haven't tried 4.2 but I would assume it's a new issue in 4.3 as there are no issues posted for 4.2. I have only tried in new 4.3 projects, haven't tried in updated projects.

@clarkfilio
Copy link

Chiming in to say I'm also seeing this on Windows 10, RTX 3070, Forward+, Godot 4.3

No issues with pre-existing Proton scatter nodes, I can edit them freely.

I'll also mention that I was seeing a weird bug with the .import of the compute_relax.glsl shader. The shader would reimport everytime I started Godot regardless of git state, about 5 seconds after running my project. I was able to fix the bug by manually reimporting the shader right after startup, before it automatically reimported. Could be entirely unrelated.

@slakibk
Copy link

slakibk commented Nov 12, 2024

Hi. So there was a problem with godot's emergency shutdown. Even just when opening a demo scene from the addon. I started the project in visual studio. The problem turned out to be in a third-party program "FPS Monitor". I don't know why, apparently it works in the background and somehow conflicts with shaders. After removing it, everything is working stably so far. Godot_v4.3 mono.
Thanks for the addon.

@SimonBradlow
Copy link

SimonBradlow commented Nov 14, 2024

Same here. Running Godot 4.3, Forward+, Windows 10, RTX 4080, 5800X3D
Tried 4.0 as well >>> Could not resolve script "res://addons/proton_scatter/src/common/scatter_util.gd

Open new project
Import addons folder
Enable the addon in project settings
Add ProtonScatter node to scene
Crash

@JekSun97

This comment was marked as off-topic.

@Klaim
Copy link

Klaim commented Nov 15, 2024

Hi. So there was a problem with godot's emergency shutdown. Even just when opening a demo scene from the addon. I started the project in visual studio. The problem turned out to be in a third-party program "FPS Monitor". I don't know why, apparently it works in the background and somehow conflicts with shaders. After removing it, everything is working stably so far. Godot_v4.3 mono. Thanks for the addon.

I dont think that's the same problem, maye create another issue?

@Klaim
Copy link

Klaim commented Nov 15, 2024

@JekSun97 This is a different problem, maybe create another issue to track it?

@slakibk
Copy link

slakibk commented Nov 16, 2024

Hi. So there was a problem with godot's emergency shutdown. Even just when opening a demo scene from the addon. I started the project in visual studio. The problem turned out to be in a third-party program "FPS Monitor". I don't know why, apparently it works in the background and somehow conflicts with shaders. After removing it, everything is working stably so far. Godot_v4.3 mono. Thanks for the addon.

I dont think that's the same problem, maye create another issue?

Here are your rules. If necessary, create a new problem. I wrote about the problem only because I found the source of the problem for my OS and fixed it. And also showed how to diagnose such problems.

@Nightl1
Copy link

Nightl1 commented Nov 23, 2024

Hi, running Godot 4.3, on Windows 10. running into the problem as well.
Steps:
Opened project.
Adding proton scatter node, it crashes.

But if i try to add scatter item node or scattershape, it doesnt crash.
Just ProtonScatter node.
Any solutions found?

@OrdnaeLP
Copy link

OrdnaeLP commented Dec 3, 2024

I am having the same problem. I was following this tutorial at 9:48:10 and after installing the addon, when I added the ProtonScatter node as a child of the environment node it loads for a couple seconds and crashes. I also have Terrain3D installed, but it caused no problem so far.
OS: Windows 11
Renderer: Forward+
GPU: Nvidia GeForce RTX 3050 Laptop GPU
CPU: AMD Ryzen 5 5600H with Radeon Graphics 3.30 GHz

edit: Tried installing Godot 4.2 and the crash does not happen. Working as intended. So it probably is a 4.3 thing!

@Randoree
Copy link

Randoree commented Dec 9, 2024

Same issue here
Godot 4.3, Forward+, Windows 10, RTX 3070Ti, i5 12400F
Had not this issue on 4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests