Specify update semantics (DataBiosphere/azul#2884) #6
Conversation
hannes-ucsc
force-pushed
the
hannes/2884-updates
branch
from
0f83349
to
7890630
Compare
hannes-ucsc
changed the title
hannes-ucsc
force-pushed
the
hannes/2884-updates
branch
3 times, most recently
from
229aebf
to
1dc1c70
Compare
hannes-ucsc
force-pushed
the
hannes/2884-updates
branch
from
7438d14
to
ba5a6b9
Compare
hannes-ucsc
force-pushed
the
hannes/2884-updates
branch
2 times, most recently
from
cdd978b
to
6820934
Compare
hannes-ucsc
dismissed
jessebrennan’s stale review
Not a binding review as per SOP.
hannes-ucsc
requested review from
clairerye,
mshadbolt,
aherbst-broad,
raaidbroad,
kbergin,
ruchim and
NoopDog
|
I am nominating @amnonkhen to take my place as reviewer. I think moving forward Claire and Amnon should be nominated as ebi reviewers and they can delegate within the ebi team as needed. |
There was a problem hiding this comment.
This looks like a reasonable approach which is in line with our current entity import and versioning. There will be work to be done to implement GC which is not surprising. I'd like @ruchim to take a pass over this as well.
|
@hannes-ucsc are you ok to remove me as a reviewer? @amnonkhen and @aaclan-ebi have approved from EBI. Thanks |
|
@clairerye Once someone did one review, their review can't be removed but your comment indicates clearly enough that you've delegated your review to @aaclan-ebi. |
Replace meta(data) with (meta)data #6 (comment)
Address rename vs moving of data files: #6 (comment)
Allow multiple versions of same entity or subgraph in non-delta staging areas. #6 (comment) #6 (comment)
Clarify "If a (b) then c (d)" language. #6 (comment) #6 (comment)
hannes-ucsc
force-pushed
the
hannes/2884-updates
branch
from
cdb84fd
to
f4e1969
Compare
hannes-ucsc
requested review from
nmalfroy,
jessicaway,
aaclan-ebi,
aherbst-broad,
amnonkhen and
NoopDog
There was a problem hiding this comment.
It would facilitate easier reading of this document, if the sections were numbered.
I cannot comment on the 1st line of the doc, but I would suggest using the sectnum directive there:
.. sectnum::
:depth: 2
:suffix: .
|
@amnonkhen, that's a good idea but has nothing to do with the goal of this PR. I've created #25 to fix it. |
hannes-ucsc
force-pushed
the
hannes/2884-updates
branch
from
20bd513
to
ef952f2
Compare
No description provided.