diff --git a/.github/workflows/push-checks.yml b/.github/workflows/push-checks.yml index 665dcce10..6c34c1e0d 100644 --- a/.github/workflows/push-checks.yml +++ b/.github/workflows/push-checks.yml @@ -30,49 +30,49 @@ jobs: with: cache: 'pip' # caching pip dependencies python-version-file: '.python-version' - - name: Install dependencies - run: | - python -m pip install --upgrade pip - pip install wheel flake8 pytest - if [ -f requirements-dev.txt ]; then pip install -r requirements-dev.txt; fi - - - name: Setup flake8 annotations - uses: rbialon/flake8-annotations@v1 - - - name: Lint with flake8 - env: - ROOT_SHA: ${{github.base_ref}} - run: | - DATA=$(jq --raw-output .before $GITHUB_EVENT_PATH) - - echo "DATA: ${DATA}" - ####################################################################### - # stop the build if there are Python syntax errors or undefined names, ignore existing - ####################################################################### - # We need to get just the *filenames* of only *python* files changed. - # Using various -z/-Z/-0 to utilise NUL-terminated strings. - git diff --name-only --diff-filter=d -z "$DATA" | \ - grep -E -z -Z '\.py$' | \ - xargs -0 flake8 --count --select=E9,F63,F7,F82 --show-source --statistics - ####################################################################### - - ####################################################################### - # 'Full' run, but ignoring docstring errors - ####################################################################### - # explicitly ignore docstring errors (start with D) - # Can optionally add `--exit-zero` to the flake8 arguments so that - git diff --name-only --diff-filter=d -z "$DATA" | \ - grep -E -z -Z '\.py$' | \ - xargs -0 flake8 --count --statistics --extend-ignore D - ####################################################################### - - - name: mypy type checks - run: | - ./scripts/mypy-all.sh --platform win32 +# - name: Install dependencies +# run: | +# python -m pip install --upgrade pip +# pip install wheel flake8 pytest +# if [ -f requirements-dev.txt ]; then pip install -r requirements-dev.txt; fi +# +# - name: Setup flake8 annotations +# uses: rbialon/flake8-annotations@v1 +# +# - name: Lint with flake8 +# env: +# ROOT_SHA: ${{github.base_ref}} +# run: | +# DATA=$(jq --raw-output .before $GITHUB_EVENT_PATH) +# +# echo "DATA: ${DATA}" +# ####################################################################### +# # stop the build if there are Python syntax errors or undefined names, ignore existing +# ####################################################################### +# # We need to get just the *filenames* of only *python* files changed. +# # Using various -z/-Z/-0 to utilise NUL-terminated strings. +# git diff --name-only --diff-filter=d -z "$DATA" | \ +# grep -E -z -Z '\.py$' | \ +# xargs -0 flake8 --count --select=E9,F63,F7,F82 --show-source --statistics +# ####################################################################### +# +# ####################################################################### +# # 'Full' run, but ignoring docstring errors +# ####################################################################### +# # explicitly ignore docstring errors (start with D) +# # Can optionally add `--exit-zero` to the flake8 arguments so that +# git diff --name-only --diff-filter=d -z "$DATA" | \ +# grep -E -z -Z '\.py$' | \ +# xargs -0 flake8 --count --statistics --extend-ignore D +# ####################################################################### +# +# - name: mypy type checks +# run: | +# ./scripts/mypy-all.sh --platform win32 - name: translation checks run: | - output=(python ./scripts/find_localised_strings.py --compare-lang L10n/en.template --directory . --ignore coriolis-data) + output=$(python ./scripts/find_localised_strings.py --compare-lang L10n/en.template --directory . --ignore coriolis-data) echo "$output" echo ${#output} if [ -n "$output" ]; then